Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even tho
heckdoes the job in most of the cases, there is another crate that is also really nice to use:convert_caseconvert_casehas some advantages:snake_casefunction, so no need for a customfn snakify(also, thefn snakifyin heck is suboptimal. Tho I'll refactor it in another PR I think)Notes
Backward compatibility
This PR doesn't break backward compatibility. Everything that was working previously with
heckwill still work.The only case where it would be false, would have been if someone put
default-features = falseonstrum-macroseven tho there wasn't any feature.About
Case::Customconvert_casealso has aCase::Customvariant that allow creating your own case!I didn't implemented it on this PR, tho it's totally feasible and not hard to do. But it just might be a bit too much for this PR