Make CTRE hardware safer for comp (and easier to debug)#20
Merged
Oliver-Cushman merged 8 commits intomainfrom Dec 13, 2024
Merged
Make CTRE hardware safer for comp (and easier to debug)#20Oliver-Cushman merged 8 commits intomainfrom
Oliver-Cushman merged 8 commits intomainfrom
Conversation
refactor Kraken.java so that it supports interaction with the StatusCode object, which allows us to have lots of debugging power which will be especially useful when we recieve the new drivebase. add javadoc to all the new ctre files alexanduzz hamiltuzz will love this
5 tasks
RudyG252
approved these changes
Dec 10, 2024
| rollSignal, | ||
| rollVelocitySignal | ||
| ).isOK(); | ||
| }; |
There was a problem hiding this comment.
Oliver after telling me it's gonna be "like 5 lines of code"
| deviceId | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
Oliver after telling me it was gonna be "like 5 lines of code".
| public void updateInputs(GyroIOInputs inputs) { | ||
| // refresh all status signals | ||
| inputs.isConnected = pigeon.isConnected(); | ||
| inputs.isConnected = pigeon.refreshSignals().isOK(); |
| @@ -96,7 +98,7 @@ public void updateInputs(ModuleIOInputs inputs) { | |||
| inputs.driveTempCelcius = driveMotor.getTemperatureAsDouble(); | |||
|
|
|||
| // Call isConnected() to refresh all status signals | |||
| driveMotor.setBrakeMode(); | ||
| } else { | ||
| driveMotor.setCoastMode(); | ||
| } |
| * Returns the velocity as a double value. | ||
| * | ||
| * @return the velocity as a double value | ||
| */ |
There was a problem hiding this comment.
On everyones soul but mine oliver wrote these javadoc headers by hand
| * | ||
| * @return the velocity as a double value | ||
| */ | ||
| public double getVelocityAsDouble() { |
There was a problem hiding this comment.
Units in method name (for most of the gets in here) 🥺
… life in a few weeks
…here for no reason lolololololol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
you get 20 tries or its over