Switch private API keys and URLs to .env files#34
Open
fstk5 wants to merge 3 commits intoPatribots4738:mainfrom
Open
Switch private API keys and URLs to .env files#34fstk5 wants to merge 3 commits intoPatribots4738:mainfrom
fstk5 wants to merge 3 commits intoPatribots4738:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
|
It should be noted that dotenv is primarily used for backend and dotenv-webpack is for frontend, for the most part. So it was the right choice, just for a little bit of a different reason |
Member
|
And u really knocked this pr out of the park in terms of documentation and explanations. Great work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New dependencies
webpack.config.jsfiles.Why were they used?
webpack.config.jsfile allowing to edit hidden or pre-configured webpack configuration files, and craco allows owerwriting or adding to those hidden files. In this case, it was used to export dotenv-webpack and dotenv to be imported intosrc/firebaseConfig.jsto allowprocess.envvariables.Are they necessary?
webpack.config.jsto export either dotenv's dependencies, since there was a breaking change in webpack version 5, or dotenv-webpack's dotenv overwrite.Testing
After running the app with the changes, there were 2 warnings and no errors in the log output. Firefox DevTools console reported 3 errors, however they were unrelated to dotenv-webpack, craco, or any other changes to the code.
Warnings
fstk5/ScoutingWebsite


Firefox DevTools Console
Output of
npm startPatribots4738/ScoutingWebsite


Firefox DevTools Console
Output of
npm startalso this is my first time making a pull request i think this is everything? mb if there's smth i missed
also i didnt use ai, this is how i write (it honestly looks like ai wrote it to me)