Skip to content

Conversation

@majochem
Copy link
Contributor

@majochem majochem commented Apr 22, 2025

Description of the problem being solved:

  • Add support for Splinter of Loratta
    • 20% increased Melee Strike Range with this weapon
    • Any number of Poisons from this Weapon can affect a target at the same time
    • Always Poison on Hit with this weapon
  • Add support for several other "with this weapon" mods by fixing the parsing pattern for "with this weapon" with modTagList. (The previous dynamic pattern resulted in false matches like "e with this weapon" within "strike range with this weapon", which led to the "strike range" mod no longer being recognized)

Steps taken to verify a working solution:

  • Mods get parsed correctly
  • Mods only apply for attacks with the weapon (not Unarmed, Herald Explosions, or Shield skills)
  • Poison chance gets overridden correctly
  • Poison stacks get overridden correctly

Limitations:

  • Breakdown explanation for "Average Poison Roll" could maybe be improved further in the future
  • "Full DPS" calculations are not accurate at the moment if you have one skill with "infinite" poison stacks and another skill with finite stacks, but it shouldn't be relevant in most scenarios and would require a lot more work in the CalcOffence section for poison DPS.

Link to a build that showcases this PR:

https://maxroll.gg/poe2/pob/0aud0i57

After screenshot:

Parsed mods
image

Strong effect of duration on poison dps
image

Poison Stack breakdown per hand
image

@majochem majochem marked this pull request as ready for review April 22, 2025 15:26
@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label May 1, 2025
@LocalIdentity LocalIdentity merged commit cafd931 into PathOfBuildingCommunity:dev May 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants