Skip to content

Conversation

@m4sc0
Copy link
Contributor

@m4sc0 m4sc0 commented Sep 25, 2025

Updated diamond sword crafting recipe details.

Updated diamond sword crafting recipe details.
@github-actions
Copy link

github-actions bot commented Sep 25, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
papermc-docs ✅ Ready (View Log) Visit Preview 3aebe92

@m4sc0
Copy link
Contributor Author

m4sc0 commented Sep 25, 2025

omg i did it wrong...

Copy link
Member

@olijeffers0n olijeffers0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not sure what happened here, idk if this was on purpose but makes sense to change…

@m4sc0
Copy link
Contributor Author

m4sc0 commented Sep 25, 2025

Maybe it would make sense to switch from a sword to a pickaxe? The current version doesn't clearly show that there are spaces before and after the letters.

@Lulu13022002
Copy link
Contributor

I think this was done on purpose (not the description), it's useless to add a craft that already exists in the game. Maybe the method could be written as:

recipe.shape(
    " A ",
    "AAA",
    " B "
);

The diamond sword would be in the middle column of the bottom row

That part is weird too it should be in the result slot?

Copy link
Member

@Strokkur424 Strokkur424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For once there is an issue with the original, which this PR is trying to fix, where this almost seems like an accident in the sword recipe. But then again, as it was pointed out, remaking a Vanilla recipe is maybe a bit weird. Thereby I suggest that we maybe find a more custom recipe. Could be something simple like a "Television" with like 8 white concrete surrounding a piece of black stained glass pane and out comes a piece of wool called "Television". I am not the most creative person, but you get the idea. I think that would clear up any misconceptions here. (Please, feel free to have your own idea here.)

Furthermore, as lulu already pointed out, this segment here is worded weirdly:

The diamond sword would be in the middle column of
the bottom row.

I am not entirely certain what this was meant to describe, but seeing as, if you remove that sentence entirely, it would still make sense, I think we can just omit it.

Switched the recipe to a television using black wool and white concrete.
@Strokkur424 Strokkur424 merged commit d5e66ff into PaperMC:main Oct 10, 2025
3 checks passed
@Strokkur424
Copy link
Member

Thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants