Skip to content

Conversation

@jopadan
Copy link

@jopadan jopadan commented Jun 3, 2023

  • Update CARHeader format sounds
  • SystemEvents in KeyChecker
  • ControlMenu now looks like ChasmPortable
  • add remappable keys present in original portable release like center_view and weapon_next/prev
  • SavesComment now contains time instead of LevelHealth
  • TGAWrite modification for screenshots
  • use strcasestr and strcasecmp
  • switch from KeyboardState to InputState allowing other input device type states
  • use char32_t instead of unsigned int for KeyCode
  • allow mouse control remap
  • allow rotate/wrap for msaa and pixel_size
  • fix character input in window resolution video menu
  • modify WriteTGA to support RGBA32 flipped input if palette equals nullptr
  • add SystemEvent support to KeyChecker
  • experimental screenshot implementation (needs testing with alpha channel support)
  • use timestamp for saves instead of Level and Health
  • add LICENSE
  • add add-on list in README.md
  • support loading new TAR format csm.bin with PhysFS

3rd party references & credits

TODO

@jopadan
Copy link
Author

jopadan commented Jun 4, 2023

@Panzerschrek As requested the changes as separate commits of the previous PR

@Panzerschrek
Copy link
Owner

@jopadan , i requested separate PRs, not separate commits within one PR.
Separate PRs are required in order to review/merge separate changes separately. With one PR (even with changes splitted per-commit) it is impossible.

@jopadan jopadan force-pushed the master branch 3 times, most recently from 12819f6 to 58317ff Compare July 17, 2023 19:51
@jopadan
Copy link
Author

jopadan commented Jul 17, 2023

Separate review is possible at the Files Changed Tab.
Opening multiple PRs requires creating separate branches and cherry-picking all the commits which is a too time consuming task.

@Panzerschrek
Copy link
Owner

@jopadan , separate review means merging separate changes separately.
Such huge PR can not be merged until all issues will be fixed.

I will try to review this, but it will take much longer time compared to approach with several separate PRs.

@jopadan jopadan force-pushed the master branch 5 times, most recently from d73ca2a to a42b1c0 Compare July 19, 2023 16:00
@jopadan jopadan changed the title Screenshots, remappable and mouse menu input Screenshot and input update, requires C++17 Jul 19, 2023
@jopadan jopadan force-pushed the master branch 2 times, most recently from 84e5001 to e4ea1ae Compare July 21, 2023 17:29
@jopadan jopadan force-pushed the master branch 2 times, most recently from 1f427c1 to 65db148 Compare August 3, 2023 19:02
@jopadan jopadan force-pushed the master branch 4 times, most recently from d749262 to aac9937 Compare November 27, 2023 18:01
@jopadan jopadan force-pushed the master branch 3 times, most recently from 4bfefe1 to d0dfd5e Compare August 12, 2024 23:00
* Fix CARHeader format sounds
* SystemEvents in KeyChecker
* ControlMenu now looks like ChasmPortable
* add remappable keys present in original portable release like center_view and weapon_next/prev
* SavesComment now contains time instead of LevelHealth
* TGAWrite modification for screenshots
* use strcasestr and strcasecmp
* switch from KeyboardState to InputState allowing other input device type states
* use char32_t instead of unsigned int for KeyCode
* allow mouse control remap
* allow rotate/wrap for msaa and pixel_size
* fix character input in window resolution video menu
* modify WriteTGA to support RGBA32 flipped input if palette equals nullptr
* add SystemEvent support to KeyChecker
* add screenshot implementation
* use timestamp for saves instead of Level and Health
* add LICENSE
* add add-on list in README.md
* add physfs and cgltf as submodule in external
* support loading new TAR format csm.bin with PhysicsFS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants