fix(theme): handle nested discriminators in allOf structures#1303
Merged
fix(theme): handle nested discriminators in allOf structures#1303
Conversation
|
Size Change: +22.1 kB (+1.01%) Total Size: 2.2 MB
ℹ️ View Unchanged
|
|
Visit the preview URL for this PR (updated for commit 121d379): https://docusaurus-openapi-36b86--pr1303-sa4n11fg.web.app (expires Thu, 19 Mar 2026 20:23:26 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: bf293780ee827f578864d92193b8c2866acd459f |
sserrata
force-pushed
the
fix/nested-oneof-discriminator
branch
from
ef2c0f9 to
b6471c4
Compare
Add support for discriminators nested within allOf schemas. Previously,
discriminators inside allOf items were not properly detected, and the
discriminator property lookup only checked top-level schema properties.
Changes:
- Add findProperty() helper to recursively search for properties in
nested oneOf/anyOf/allOf structures
- Update DiscriminatorNode to use findProperty() for discriminator
property lookup
- Update SchemaNode to check for discriminators in allOf items and
merge schemas before processing
- Return null instead of empty "object" SchemaItem when properties
are empty after discriminator processing
- Add test case for nested discriminator in allOf
This fixes scenarios like:
```yaml
allOf:
- $ref: CommonProps
- oneOf: [VariantA, VariantB]
discriminator:
propertyName: type
```
Fixes #1302
Handle recursively nested discriminators in composed schemas while preserving intentional empty-object rendering, and add demo specs covering deep allOf discriminator chains and explicit empty object properties. Co-authored-by: Cursor <cursoragent@cursor.com>
sserrata
force-pushed
the
fix/nested-oneof-discriminator
branch
from
b6471c4 to
121d379
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for discriminators nested within allOf schemas. Previously, discriminators inside allOf items were not properly detected, and the discriminator property lookup only checked top-level schema properties.
Changes:
This fixes scenarios like:
Fixes #1302