Skip to content

collect duration after recover #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mloo3 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

collect duration after recover #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f20fd5f
collect duration after recover
May 19, 2023
8ccdf23
lint fix
May 20, 2023
65949fa
latest golangci-lint does not work with go 1.18
May 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-go.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,14 @@ jobs:
go install github.com/AlekSi/gocov-xml@latest

- name: setup-for-older-go
if: ${{ matrix.go <= 1.17 }}
if: ${{ matrix.go <= 1.18 }}
run: |
# stay on an older version of golangci-lint which still builds against 1.17
# This is due to the introduction of generics.
go install github.com/golangci/golangci-lint/cmd/[email protected]

- name: setup-for-newer-go
if: ${{ matrix.go > 1.17 }}
if: ${{ matrix.go > 1.18 }}
run: |
go install github.com/golangci/golangci-lint/cmd/golangci-lint@latest

Expand Down
3 changes: 2 additions & 1 deletion printer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,9 @@ func printSetupError(id, suite, name string, recovery interface{}, err error) {
fmt.Printf("%s\n",
goterm.Bold(
goterm.Color(
fmt.Sprintf("%s FAIL %s",
fmt.Sprintf("%s: %s FAIL %s",
id,
suite,
name,
),
goterm.YELLOW,
Expand Down
5 changes: 3 additions & 2 deletions runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ func (r *testRunner) executeIteration(ctx context.Context, currTest testRun, res
var data interface{}
var td TearDownFunction
var err error
var start time.Time

buf := &bytes.Buffer{}

Expand All @@ -102,6 +103,7 @@ func (r *testRunner) executeIteration(ctx context.Context, currTest testRun, res

// recover remote code.
r := recover()
ti.duration = time.Since(start)
if r == nil {
return
}
Expand Down Expand Up @@ -144,9 +146,8 @@ func (r *testRunner) executeIteration(ctx context.Context, currTest testRun, res
}()
}

start := time.Now()
start = time.Now()
ti.err = t.test.Function(ctx, subTestInfo)
ti.duration = time.Since(start)

}(currTest, i)
}
Expand Down