Skip to content

Async-friendly decompress#145

Draft
droundy wants to merge 7 commits intoPSeitz:mainfrom
droundy:async-decompress
Draft

Async-friendly decompress#145
droundy wants to merge 7 commits intoPSeitz:mainfrom
droundy:async-decompress

Conversation

@droundy
Copy link
Copy Markdown

@droundy droundy commented Jul 16, 2023

I started creating an alternate decompressor that would work better with async than the Read based one you have. The issue is that in my async program the bytes come over the network in chunks and I can't write a non-async Read without introducing additional plumbing that I'd rather avoid.

This PR isn't very good yet, but I'm wondering if something like this would be of interest to you?

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 16, 2023

Codecov Report

❌ Patch coverage is 0% with 205 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.21%. Comparing base (23b05b0) to head (bfa4fc8).
⚠️ Report is 48 commits behind head on main.

Files with missing lines Patch % Lines
src/frame/raw_decompress.rs 0.00% 205 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
- Coverage   89.02%   82.21%   -6.81%     
==========================================
  Files          13       13              
  Lines        2478     2682     +204     
==========================================
- Hits         2206     2205       -1     
- Misses        272      477     +205     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PSeitz
Copy link
Copy Markdown
Owner

PSeitz commented Jul 17, 2023

I'm open to add async support, if the code is not duplicated.
There's also the risk of blocking the async runtime, by doing too much work on a task, so the additional plumbing may be a good thing.

Related issue: #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants