Skip to content

Conversation

@jared321
Copy link
Collaborator

@jared321 jared321 commented Jan 27, 2026

This should resolve Issue #253.

PR Self-review

  • Review all changes
  • Review oldest GH action's logs
  • Confirm all actions passing

oldest tox task passing locally.
@jared321 jared321 self-assigned this Jan 27, 2026
@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.49%. Comparing base (9ede9de) to head (38aafa0).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #254   +/-   ##
=======================================
  Coverage   94.49%   94.49%           
=======================================
  Files          93       93           
  Lines        3618     3618           
=======================================
  Hits         3419     3419           
  Misses        199      199           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jared321 jared321 requested a review from jmlarson1 January 27, 2026 19:41
@jmlarson1
Copy link
Collaborator

Any reason why we need jaxlib as a dep in ibcdfo_pypkg/tox.ini‎ but not one of the dependencies in ibcdfo_pypkg/pyproject.toml?

@jared321
Copy link
Collaborator Author

jared321 commented Jan 28, 2026

In pyproject.toml we should likely specify only the minimum number of external dependencies possible. Specifically, we should only include those dependencies that we know we use explicitly. This includes jax . If other packages have external dependencies, we let pip figure out those dependencies itself by interrogating those packages. In this case, jax depends on jaxlib , which makes good sense. No need for us to specify jaxlib there.

In the oldest test, I want to control the test's venv carefully to ensure that we are indeed testing the oldest versions. I don't know if pip would install a more modern version of jaxlib if I didn't specify a specific version for jaxlib . So, it the name of being conservative, I specified both versions after manually checking that those are the two oldest, compatible versions that can be installed side-by-side.

Part of this is the fact that those two packages are separate, but (I suspect) intimately related. I almost wonder if they are two packages that effectively work as one.

@jared321 jared321 merged commit 5ca99d4 into main Jan 28, 2026
45 checks passed
@jared321 jared321 mentioned this pull request Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants