Skip to content

Conversation

@znichollscr
Copy link
Collaborator

@znichollscr znichollscr commented Mar 14, 2025

Description

Resolves the key point of #222 (not closing as there are other discussions appearing there).

Checklist

Please confirm that this pull request has done the following:

@github-actions
Copy link

No changes to the database between 'main' branch and c93f69d

@znichollscr znichollscr requested a review from durack1 March 14, 2025 17:44
@github-actions
Copy link

No changes to the database between 'main' branch and a141afb

@github-actions
Copy link

No changes to the database between 'main' branch and fe9a726

Copy link
Collaborator

@durack1 durack1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@znichollscr couple of nits. The more we can simplify this the better in my opinion. With CMIP6 we had the google doc which allowed data providers to fill in whatever info they liked, so we'd want to attempt to allow the same things time around IMHO

@github-actions
Copy link

No changes to the database between 'main' branch and 84ea893

@github-actions
Copy link

No changes to the database between 'main' branch and 16a6b16

@znichollscr
Copy link
Collaborator Author

allowed data providers to fill in whatever info they liked, so we'd want to attempt to allow the same things time around IMHO

As a note, they can. They just can't do it within the auto-generated sections

@durack1
Copy link
Collaborator

durack1 commented Mar 16, 2025

@znichollscr what's the live PR #223 HTML preview again? I have been trying a couple of variants URLs and can't figure it out

@github-actions
Copy link

No changes to the database between 'main' branch and a2c24b2

@znichollscr
Copy link
Collaborator Author

@znichollscr what's the live PR #223 HTML preview again? I have been trying a couple of variants URLs and can't figure it out

Ah yes one of the consequences of #224 was that we broke the previews. I've update them now. To find the link in future, see the screenshots below

Next to each commit that is pushed, there is a small button for the CI (either a yellow dot, red cross or green tick depending on the status)

image

Open up that panel, scroll down to read the docs, then open up the 'details' link, that takes you to the preview

image

@github-actions
Copy link

No changes to the database between 'main' branch and 6fb4637

@znichollscr
Copy link
Collaborator Author

Paul on holidays, merging

@znichollscr znichollscr merged commit 996acad into main Mar 18, 2025
7 checks passed
@znichollscr znichollscr deleted the remove-fast-track branch March 18, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants