Skip to content

Conversation

@rhoesly
Copy link
Contributor

@rhoesly rhoesly commented Dec 19, 2024

Add CEDS documentation for slcf and co2.

Copy link
Contributor

@znicholls znicholls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice, thanks!

One other thought: if some of this information is a duplication of things already on the CEDS page, I think it would also be ok to have less information here and just point people to the underlying CEDS documentation rather than duplicating. Up to you

Copy link
Collaborator

@durack1 durack1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to augment this with DOI links, so that an interested user can help themselves, rather than having to ask more questions, or spend an hour doing a fruitless google search that could be avoided

@rhoesly
Copy link
Contributor Author

rhoesly commented Dec 20, 2024

It would be great to augment this with DOI links, so that an interested user can help themselves, rather than having to ask more questions, or spend an hour doing a fruitless google search that could be avoided

doi links added

@znichollscr
Copy link
Collaborator

Added final fixes to get the CI passing in rhoesly#1

@durack1
Copy link
Collaborator

durack1 commented Jan 3, 2025

@znichollscr is this good to merge?

@znichollscr
Copy link
Collaborator

@znichollscr is this good to merge?

No waiting on rhoesly#1

@rhoesly
Copy link
Contributor Author

rhoesly commented Jan 3, 2025

this is good to go!

@znichollscr
Copy link
Collaborator

znichollscr commented Jan 3, 2025 via email

Fix up line endings and other minor fixes
@durack1
Copy link
Collaborator

durack1 commented Jan 7, 2025

@znichollscr looks like we're off and running - want to merge?

@znichollscr
Copy link
Collaborator

Ok the failing CR is due to the PR coming from a fork. One to sort out in future.

@znichollscr znichollscr merged commit a207d67 into PCMDI:main Jan 7, 2025
5 of 6 checks passed
@znichollscr znichollscr mentioned this pull request Jan 7, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants