Initial commit of new places taxonomy #420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwass
added
the
change type - minor 🤏
jwass
requested review from
TristanDiet-TomTom,
jonahadkins,
sasastanojkov and
vcschapp
jenningsanderson
previously approved these changes
Dec 1, 2025
Collaborator
jenningsanderson
left a comment
jenningsanderson
left a comment
There was a problem hiding this comment.
👍 Pydantic changes look good, too!
sasastanojkov
previously approved these changes
Dec 2, 2025
TristanDiet-TomTom
previously approved these changes
Dec 2, 2025
vcschapp
reviewed
Dec 3, 2025
packages/overture-schema-places-theme/src/overture/schema/places/place.py
Outdated
Show resolved
Hide resolved
vcschapp
reviewed
Dec 3, 2025
packages/overture-schema-places-theme/src/overture/schema/places/place.py
Outdated
Show resolved
Hide resolved
vcschapp
reviewed
Dec 3, 2025
packages/overture-schema-places-theme/src/overture/schema/places/place.py
Outdated
Show resolved
Hide resolved
vcschapp
reviewed
Dec 3, 2025
packages/overture-schema-places-theme/src/overture/schema/places/place.py
Show resolved
Hide resolved
vcschapp
reviewed
Dec 3, 2025
vcschapp
reviewed
Dec 3, 2025
vcschapp
reviewed
Dec 3, 2025
packages/overture-schema-places-theme/src/overture/schema/places/place.py
Show resolved
Hide resolved
vcschapp
reviewed
Dec 3, 2025
vcschapp
reviewed
Dec 3, 2025
vcschapp
reviewed
Dec 3, 2025
Collaborator
vcschapp
left a comment
vcschapp
left a comment
There was a problem hiding this comment.
It looks pretty good. I picked a few nits and also called out the sad and sorry need to duplicate the examples/counterexamples.
jwass
dismissed stale reviews from TristanDiet-TomTom, sasastanojkov, and jenningsanderson
via
28846c2
danabauer
reviewed
Dec 3, 2025
packages/overture-schema-places-theme/src/overture/schema/places/place.py
Show resolved
Hide resolved
TristanDiet-TomTom
previously approved these changes
Dec 3, 2025
vcschapp
reviewed
Dec 3, 2025
packages/overture-schema-places-theme/src/overture/schema/places/place.py
Outdated
Show resolved
Hide resolved
vcschapp
approved these changes
Dec 3, 2025
danabauer
approved these changes
Dec 3, 2025
sasastanojkov
approved these changes
Dec 3, 2025
vcschapp
pushed a commit
that referenced
this pull request
Dec 4, 2025
* Initial commit of new places taxonomy * Fix TX region * Add operating_status to bad-categories-value * Fix mistakenly change alternate -> alternates * Revert change to bad categories counterexample * Add pydantic model for new taxonomy * Fix up place baseline schema json * Copy examples/couterexamples to references. Update docs * Update main place.yaml file to reflect unique/minItems constraints * Add backtick and reference to Places doc page * Update baseline json
patryklikus-tomtom
pushed a commit
to patryklikus-tomtom/OvertureMaps-schemas
that referenced
this pull request
Dec 4, 2025
* Initial commit of new places taxonomy * Fix TX region * Add operating_status to bad-categories-value * Fix mistakenly change alternate -> alternates * Revert change to bad categories counterexample * Add pydantic model for new taxonomy * Fix up place baseline schema json * Copy examples/couterexamples to references. Update docs * Update main place.yaml file to reflect unique/minItems constraints * Add backtick and reference to Places doc page * Update baseline json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
B. Related MINOR change steps
C. Public documentation and messaging plan
TODO.
Description
Brief description of the business purpose and effect of the pull request.
Adds the new categorization description for Overture's new taxonomy. This includes
specifying the primary category and the hierarchy from most general to most specific. The
schema includes the ability to specify alternates, but those are only the strings.
Reference
List of relevant links to GitHub issues, PRs, and other documentation.
Testing
Brief description of the testing done for this change showing why you are confident it works as expected and does not introduce regressions. Provide sample output data where appropriate.
TODO.
Checklist
Checklist of tasks commonly-associated with schema pull requests. Please review the relevant checklists and ensure you do all the tasks that are required for the change you made.
Abut is not intended to test propertyA's validity, and you made a schema change that invalidates propertyAin that counterexample, fix the counterexample to align it with your schema change.Documentation website
Update the hyperlink below to put the pull request number in.
[Docs preview for this PR.](https://dfhx9f55j8eg5.cloudfront.net/pr/<PUT THE PR # HERE>)