[WIP] Opening Hours Extension Proof-of-Concept DO NOT MERGE #416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenningsanderson
temporarily deployed
to
staging
GitHub Actions
Inactive
danabauer
reviewed
Nov 26, 2025
|
|
||
| 1. Inherit from `Identified` to get the `id` field (instead of full `OvertureFeature`) | ||
| 2. Add custom fields with proper annotations and descriptions | ||
| 3. Create supporting models with `@no_extra_fields` decorator |
Contributor
There was a problem hiding this comment.
the name for this decorator -- @no_extra_fields -- could be confusing for builders. Are we asking them to make clear which properties are core? I can address this in the main Pydantic packages for schema
danabauer
reviewed
Nov 26, 2025
| ] = None | ||
|
|
||
|
|
||
| class PlaceWithOperatingHours(Place): |
Contributor
There was a problem hiding this comment.
why are you not using the @no_extra_fields decorator here?
jenningsanderson
force-pushed
the
opening-hours-extension
branch
from
a732da4 to
a11751f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof-of-concept of what an Overture Schema Extension might look like.
Putting it here because it requires the pydantic schema, but in the future, it likely belongs in its own repo.