Add ROLLER_COASTER enum to enums.py #411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenningsanderson
temporarily deployed
to
staging
GitHub Actions
Inactive
mojodna
approved these changes
Oct 23, 2025
mojodna
requested changes
Oct 28, 2025
Collaborator
mojodna
left a comment
mojodna
left a comment
There was a problem hiding this comment.
Please re-baseline the generated schema to reflect this addition.
vcschapp
reviewed
Oct 29, 2025
Collaborator
vcschapp
left a comment
vcschapp
left a comment
There was a problem hiding this comment.
LGTM (once re-baselined per Seth's request).
jenningsanderson
force-pushed
the
add-roller-coaster-2
branch
from
7c0c8e6 to
11f1840
Compare
jenningsanderson
temporarily deployed
to
staging
GitHub Actions
Inactive
jenningsanderson
force-pushed
the
add-roller-coaster-2
branch
from
11f1840 to
5e533bb
Compare
jenningsanderson
temporarily deployed
to
staging
GitHub Actions
Inactive
mojodna
reviewed
Nov 4, 2025
Collaborator
mojodna
left a comment
mojodna
left a comment
There was a problem hiding this comment.
Did you manually edit/reformat infrastructure_baseline_schema.json? The idea is that you delete it, re-run the test (to re-create the file), confirm that the git diff matches your expectations, and then commit the change.
I'm puzzled by the differences...
jenningsanderson
added
change type - minor 🤏
mojodna
approved these changes
Nov 4, 2025
vcschapp
pushed a commit
that referenced
this pull request
Nov 26, 2025
* Add ROLLER_COASTER enum to enums.py
vcschapp
pushed a commit
that referenced
this pull request
Dec 4, 2025
* Add ROLLER_COASTER enum to enums.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
roller_coasterto list of enums for infrastructureGoes with https://github.com/OvertureMaps/tf-data-platform/pull/1979/files