-
Notifications
You must be signed in to change notification settings - Fork 12
Add class to divisions schema #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
vcschapp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple checklist items outstanding:
- Can you add examples and counterexamples please?
- Chat with Dana about any Docusaurus docs updates for divisions page?
jonahadkins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆗
|
cc @vcschapp / @TristanDiet-TomTom for sign off on the series of divisions schema changes. |
2e7a4af
|
Changes are approved by all needed approvers, but I pushed a cosmetic commit to fix the "missing newline at end of file" issue in I'll merge based on the approvals already given. |
Category
What kind of change is this?
Please select one of the following four options.
Consult Pull request merging criteria for a description of each category.
Description
This fixes a portion of https://github.com/OvertureMaps/tf-admin/issues/82 and replaces #294.
This pull request adds a
classproperty to the divisons schema.class: For the divisions type, this field would explicitly call out the type of locality (hamlet, city, etc.) being represented. As a v1, we'd essentially repurpose the local_type en value to create this enum.As a follow up, a
prominenceproperty and usage (is_processing/is_rendering?) will likely be added to the divisions schema.Reference
List of relevant links to GitHub issues, PRs, and other documentation.
https://github.com/OvertureMaps/tf-admin/issues/82
#294
Testing
Brief description of the testing done for this change showing why you are confident it works as expected and does not introduce regressions. Provide sample output data where appropriate.
TODO.
Checklist
Checklist of tasks commonly-associated with schema pull requests. Please review the relevant checklists and ensure you do all the tasks that are required for the change you made.
Abut is not intended to test propertyA's validity, and you made a schema change that invalidates propertyAin that counterexample, fix the counterexample to align it with your schema change.Documentation Website
Update the hyperlink below to put the pull request number in.
Docs preview for this PR.