Skip to content

Conversation

@jonahadkins
Copy link
Contributor

@jonahadkins jonahadkins commented May 30, 2024

Proposal

Add ocean and inland lakes bathymetry data. Examples below from Meta's production basemaps.

Screenshot 2024-05-30 at 6 08 02 PM Screenshot 2024-05-30 at 6 08 20 PM Screenshot 2024-05-30 at 6 12 44 PM Screenshot 2024-05-30 at 6 13 30 PM

Background

The Display Maps team at Meta derived vectorized bathymetric data products from ETOPO1 and Globathy.

ETOPO (source link)

We derived 10 bands of polygons from this dataset, at the following depths:

feature count depth
4,285 0
4,228 10
4,622 50
3,878 100
2,748 500
3,308 1000
4,722 1500
6,750 2000
10,309 2500
15,210 3000

GLOBathy (source link)

For interior water bodies, we have derived vectorized data for 10 global lakes: Lake Baikal, Lake Tanganyika, Lake Malawi, Lago Niassa, Garabogazköl, Lake Superior, Lake Michigan, Lake Ontario, Crater Lake, and Lake Tahoe. We derived 15 bands of polygons from this dataset, at the following depths:

feature count depth
14 100
12 200
8 300
8 400
8 500
7 600
3 700
8 800
8 900
6 1000
8 1100
4 1200
4 1300
3 1400
1 1500

License

ETOPO: PDDL

ETOPO tiles are freely available to use for all private, academic, or commercial purposes. Data is
available for download on the NOAA ETOPO landing page.
To reference the ETOPO 2022 document, please cite the following:
NOAA National Centers for Environmental Information. 2022: ETOPO 2022 15 Arc-Second
Global Relief Model. NOAA National Centers for Environmental Information.
https://doi.org/10.25921/fd45-gt74 . Accessed [date].
ETOPO 2022 metadata may be accessed here: ETOPO 2022 metadata landing page

GLOBathy: CC0 1.0

The dataset is released under an assumed CC0 1.0 Universal (CC0 1.0) Public Domain Dedication. The organizations responsible for generating and funding this dataset make no representations of any kind including, but not limited to the warranties of merchantability or fitness for a particular use, nor are any such warranties to be implied with respect to the data. Although every effort has been made to ensure the accuracy of information, errors may be reflected in data supplied. The user must be aware of data conditions and bear responsibility for the appropriate use of the information with respect to possible errors.

Checklist

Checklist of tasks commonly-associated with schema pull requests. Please review the relevant checklists and ensure you do all the tasks that are required for the change you made.

  1. Add relevant examples.
  2. [N/A] Add relevant counterexamples.
  3. Update any counterexamples that became obsolete. For example, if a counterexample uses property A but is not intended to test property A's validity, and you made a schema change that invalidates property A in that counterexample, fix the counterexample to align it with your schema change.
  4. Update in-schema documentation using plain English written in complete sentences, if an update is required.
  5. Update Docusaurus documentation, if an update is required.
  6. Review change with Overture technical writer to ensure any advanced documentation needs will be taken care of, unless the change is trivial and would not affect the documentation.

Documentation Website

Update the hyperlink below to put the pull request number in.

Docs preview for this PR.

@vcschapp
Copy link
Collaborator

We should try to boot this PR up and aim for September or October release. Not rushing due to GA and post-GA freeze but should be in!

Copy link
Collaborator

@jenningsanderson jenningsanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved once validation errors are passing

DavidKarlas
DavidKarlas previously approved these changes Nov 20, 2024
@vcschapp
Copy link
Collaborator

@jonahadkins Schema TF finally made a decision! We are going to move forward with merging this change ASAP.

Can you take a look at fixing the validation errors and any unresolved comments?

add depth prop
update schema
@vcschapp vcschapp merged commit 149147c into dev Dec 11, 2024
1 check passed
@vcschapp
Copy link
Collaborator

Merged! Wooooooo!

@vcschapp vcschapp deleted the bathymetry-2 branch December 11, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.