-
Notifications
You must be signed in to change notification settings - Fork 12
Add Bathymetry to Base #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8cd6a47 to
9eff25f
Compare
c510363 to
e5445f7
Compare
e5445f7 to
d7fc150
Compare
|
We should try to boot this PR up and aim for September or October release. Not rushing due to GA and post-GA freeze but should be in! |
7cadd34 to
3f4a42b
Compare
jenningsanderson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved once validation errors are passing
|
@jonahadkins Schema TF finally made a decision! We are going to move forward with merging this change ASAP. Can you take a look at fixing the validation errors and any unresolved comments? |
f21379f
685830f to
7ab9acc
Compare
add depth prop
update schema
|
Merged! Wooooooo! |
Proposal
Add ocean and inland lakes bathymetry data. Examples below from Meta's production basemaps.
Background
The Display Maps team at Meta derived vectorized bathymetric data products from ETOPO1 and Globathy.
ETOPO (source link)
We derived 10 bands of polygons from this dataset, at the following depths:
GLOBathy (source link)
For interior water bodies, we have derived vectorized data for 10 global lakes: Lake Baikal, Lake Tanganyika, Lake Malawi, Lago Niassa, Garabogazköl, Lake Superior, Lake Michigan, Lake Ontario, Crater Lake, and Lake Tahoe. We derived 15 bands of polygons from this dataset, at the following depths:
License
ETOPO: PDDL
GLOBathy: CC0 1.0
Checklist
Checklist of tasks commonly-associated with schema pull requests. Please review the relevant checklists and ensure you do all the tasks that are required for the change you made.
Abut is not intended to test propertyA's validity, and you made a schema change that invalidates propertyAin that counterexample, fix the counterexample to align it with your schema change.Documentation Website
Update the hyperlink below to put the pull request number in.
Docs preview for this PR.