Skip to content

Conversation

@koji
Copy link
Contributor

@koji koji commented Oct 17, 2025

Overview

update labware containers (source labware container and destination labware container)

Test Plan and Hands on Testing

  • open the desktop app
  • select a Flex protocol that includes liquid transfer
  • click visualize button

Changelog

Review requests

Risk assessment

low

@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 0% with 305 lines in your changes missing coverage. Please review.
✅ Project coverage is 23.82%. Comparing base (c2dfd3d) to head (18808c8).
⚠️ Report is 2 commits behind head on edge.

Files with missing lines Patch % Lines
...tocolVisualization/DestinationLabwareContainer.tsx 0.00% 83 Missing ⚠️
...p/ProtocolVisualization/SourceLabwareContainer.tsx 0.00% 71 Missing ⚠️
...rotocolVisualization/utils/getSlotIdFromCommand.ts 0.00% 71 Missing ⚠️
...ktop/ProtocolVisualization/StepDetailContainer.tsx 0.00% 41 Missing ⚠️
...Visualization/utils/getWellFillFromWellContents.ts 0.00% 27 Missing ⚠️
...cols/ProtocolVisualization/VisualizerContainer.tsx 0.00% 12 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #19827      +/-   ##
==========================================
- Coverage   24.98%   23.82%   -1.17%     
==========================================
  Files        3522     3522              
  Lines      294916   295166     +250     
  Branches    39698    39697       -1     
==========================================
- Hits        73675    70312    -3363     
- Misses     221219   224833    +3614     
+ Partials       22       21       -1     
Flag Coverage Δ
app 0.31% <0.00%> (-2.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...cols/ProtocolVisualization/VisualizerContainer.tsx 0.00% <0.00%> (ø)
...Visualization/utils/getWellFillFromWellContents.ts 0.00% <0.00%> (ø)
...ktop/ProtocolVisualization/StepDetailContainer.tsx 0.00% <0.00%> (ø)
...p/ProtocolVisualization/SourceLabwareContainer.tsx 0.00% <0.00%> (ø)
...rotocolVisualization/utils/getSlotIdFromCommand.ts 0.00% <0.00%> (ø)
...tocolVisualization/DestinationLabwareContainer.tsx 0.00% <0.00%> (ø)

... and 76 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@koji koji requested review from jerader and ncdiehl11 October 17, 2025 21:26
@koji koji marked this pull request as ready for review October 17, 2025 21:26
@koji koji changed the title Feat update labware containers feat(app): update labware containers Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants