Reduce OpenSSL monkey patch to only calling set_params#308
Open
ekohl wants to merge 1 commit intoOpenVoxProject:mainfrom
Open
Reduce OpenSSL monkey patch to only calling set_params#308ekohl wants to merge 1 commit intoOpenVoxProject:mainfrom
ekohl wants to merge 1 commit intoOpenVoxProject:mainfrom
Conversation
ruby-openssl has always merged the passed params with default params, so this is redundant. It's still a difference that the default SSLContext does not call set_params and expects the caller to do so. Link: https://github.com/ruby/openssl/blob/b814041f4fa2c64f0d2092c38bc2615a770f11c4/lib/openssl/ssl.rb#L113
Contributor
Author
Looking at 52be043 I'm not 100% sure if it's really needed, but this is dark magic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ruby-openssl has always merged the passed params with default params, so this is redundant.
It's still a difference that the default SSLContext does not call
set_paramsand expects the caller to do so.Link: https://github.com/ruby/openssl/blob/b814041f4fa2c64f0d2092c38bc2615a770f11c4/lib/openssl/ssl.rb#L113