Merged
Conversation
nmburgan
approved these changes
Aug 26, 2025
rwaffen
approved these changes
Aug 26, 2025
Contributor
|
@binford2k can you please rebase? Tests should pass afterwards. |
ekohl
reviewed
Aug 26, 2025
Comment on lines
+174
to
175
| Puppet::FileSystem.dir_mkpath(path) | ||
| Puppet::FileSystem.touch(path) |
Contributor
There was a problem hiding this comment.
A thought to go in the other direction: should it return if the file doesn't exist? What's the point in creating an empty file and then reading it?
Contributor
Author
There was a problem hiding this comment.
it's not "reading" the file, it's opening it and manipulating it. Which ultimately means either changing the contents or adding content -- but the difference is irrelevant.
binford2k
force-pushed
the
binford2k-patch-1
branch
from
2539cc0 to
1a6c249
Compare
Prior to this, if OpenVox was installed via gem and the first command you run is setting configuration then it fails because `confdir` doesn't exist yet. This corrects that. It doesn't bother setting permissions because future runs will correct the permissions.
binford2k
force-pushed
the
binford2k-patch-1
branch
from
1a6c249 to
ef2398c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this, if OpenVox was installed via gem and the first command you run is setting configuration then it fails because
confdirdoesn't exist yet. This corrects that.It doesn't bother setting permissions because future runs will correct the permissions.