Fix image_data comment on pixel order#684
Closed
thomassedlmayer wants to merge 1 commit intoOpenSimulationInterface:masterfrom
Closed
Fix image_data comment on pixel order#684thomassedlmayer wants to merge 1 commit intoOpenSimulationInterface:masterfrom
thomassedlmayer wants to merge 1 commit intoOpenSimulationInterface:masterfrom
Conversation
Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>
jdsika
approved these changes
Nov 4, 2022
Contributor
|
CCB 2022-11-07: Still to be discussed in sensor group, hence postponed at CCB. |
raue
approved these changes
Dec 5, 2022
6 tasks
Contributor
|
replaced by #698 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We noticed that the pixel order of the image_data field in CameraSensorView was not specified by CameraSensorViewConfiguration as the description of image_data says:
Since both radar and lidar reflections are currently defined to be ordered left-to-right, top-to-bottom (see following quote), it could be the case that this was accidently omitted for image_data. (RadarSensorView, LidarSensorView)
Therefore, the default pixel order should probably align with the definitions of radar and lider reflections. If further pixel orders are desired a enum could be added to CameraSensorViewConfiguration but I think this small change would already clarify enough to be able to reliably exchange image data with OSI.
This change can be seen as a bug fix. The description of image_data that a pixel order can be specified in CameraSensorViewConfiguration is definitely misleading.
Checklist
#### References
#681