F OpenNebula/one-deploy#125: Add support for fully automating LVM shared LUN datastore setup

roles/datastore/frontend/README.md

@@ -11,12 +11,12 @@ N/A
 Role Variables
 --------------
 
-| Name         | Type   | Default   | Example       | Description                                                                    |
-|--------------|--------|-----------|---------------|--------------------------------------------------------------------------------|
-| `ds.mode`    | `str`  | `ssh`     |               | OpenNebula Datastore configuration mode: `ssh`, `shared`, `ceph` or `generic`. |
-| `ds.config`  | `dict` | `{}`      | (check below) | OpenNebula Datastore configuration for a specifc mode.                         |
-| `node_group` | `str`  | `node`    |               | Custom name of the Node group in the inventory.                                |
-| `leader`     | `str`  | undefined | `10.11.12.13` | When OpenNebula is in HA mode it points to the Leader.                         |
+| Name         | Type   | Default   | Example       | Description                                                                                  |
+|--------------|--------|-----------|---------------|----------------------------------------------------------------------------------------------|
+| `ds.mode`    | `str`  | `ssh`     |               | OpenNebula Datastore configuration mode: `ssh`, `shared`, `ceph`, `fs_lvm_ssh` or `generic`. |
+| `ds.config`  | `dict` | `{}`      | (check below) | OpenNebula Datastore configuration for a specifc mode.                                       |
+| `node_group` | `str`  | `node`    |               | Custom name of the Node group in the inventory.                                              |
+| `leader`     | `str`  | undefined | `10.11.12.13` | When OpenNebula is in HA mode it points to the Leader.                                       |
 
 Dependencies
 ------------
@@ -64,6 +64,19 @@ Example Playbook
         - role: opennebula.deploy.helper.facts
         - role: opennebula.deploy.datastore.frontend
 
+    - hosts: frontend
+      vars:
+        # Configure OpenNebula to use "fs_lvm_ssh" image and system datastores.
+        # LVM devices are specified per SYSTEM_DS
+        ds:
+          mode: fs_lvm_ssh
+          config:
+            SYSTEM_DS:
+              device: /dev/mapper/mpatha
+      roles:
+        - role: opennebula.deploy.helper.facts
+        - role: opennebula.deploy.datastore.frontend
+
     - hosts: frontend
       vars:
         # Configure OpenNebula to use "shared" image and system datastores.

roles/datastore/frontend/tasks/main.yml

@@ -8,6 +8,7 @@
       ssh: simple
       ceph: simple
       shared: simple
+      fs_lvm_ssh: simple
       generic: generic
   when:
     - ds.mode is defined

roles/datastore/node/tasks/main.yml

@@ -8,6 +8,7 @@
       ssh: simple
       ceph: simple
       shared: simple
+      fs_lvm_ssh: simple
       generic: generic
   when:
     - ds.mode is defined

roles/datastore/simple/defaults/main.yml

@@ -47,3 +47,15 @@ ds_defaults:
     FILE_DS:
       template:
         TM_MAD: ssh
+  fs_lvm_ssh:
+    SYSTEM_DS:
+      template:
+        TM_MAD: fs_lvm_ssh
+        BRIDGE_LIST: "{{ groups[node_group | d('node')] | map('extract', hostvars, ['ansible_host']) | join(' ') }}"
+      device: ""
+    IMAGE_DS:
+      template:
+        TM_MAD: fs_lvm_ssh
+    FILE_DS:
+      template:
+        TM_MAD: ssh

roles/datastore/simple/tasks/node.yml

@@ -2,6 +2,44 @@
 - ansible.builtin.import_tasks:
     file: "{{ role_path }}/tasks/common.yml"
 
+- name: Ensure LVM PV and VG exist (fs_lvm_ssh system)
+  ansible.builtin.shell: &lvm_shell
+    cmd: |
+      set -o errexit
+
+      if ! [[ -b '{{ _device }}' ]]; then
+        echo "Device '{{ _device }}' does not exist or is not a block device." >&2
+        exit 1
+      fi
+
+      if ! pvdisplay '{{ _device }}' &>/dev/null; then
+        if ! pvcreate '{{ _device }}'; then
+          echo "Failed to create PV '{{ _device }}'" >&2
+          exit 1
+        fi
+      fi
+
+      if ! vgdisplay "vg-one-{{ _ds_id }}" &>/dev/null; then
+        if ! vgcreate "vg-one-{{ _ds_id }}" '{{ _device }}'; then
+          echo "Failed to create VG 'vg-one-{{ _ds_id }}'" >&2
+          exit 1
+        fi
+      fi
+
+      exit 78
+    executable: /bin/bash
+  loop: "{{ ds_items.system | default([]) }}"
+  loop_control:
+    loop_var: item
+  vars:
+    _ds_id: "{{ item.1.ID }}"
+    _device: "{{ ds.config.SYSTEM_DS.device | default(ds_defaults[ds.mode].SYSTEM_DS.device) }}"
+  when: ds.mode == "fs_lvm_ssh"
+  register: lvm_shell
+  changed_when: lvm_shell.rc == 78
+  failed_when: lvm_shell.rc != 0 and lvm_shell.rc != 78
+  run_once: true
+
 - when: ds.mode != 'ssh'
   block:
     - name: Setup datastore symlinks (image)