NMS-19082 Enable Kafka Producer to sent separate topics to different kafka servers #8150
+854
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mohammad-Junid
requested review from
aurang-zeb313,
cgorantla and
mwajahatabbasi
aurang-zeb313
requested changes
Nov 25, 2025
...s/kafka/producer/src/main/java/org/opennms/features/kafka/producer/KafkaProducerManager.java
Outdated
Show resolved
Hide resolved
...s/kafka/producer/src/main/java/org/opennms/features/kafka/producer/KafkaProducerManager.java
Show resolved
Hide resolved
cgorantla
requested changes
Nov 26, 2025
Contributor
cgorantla
left a comment
cgorantla
left a comment
There was a problem hiding this comment.
We are missing a critical piece here. We need this for metrics as well with KafkaPersisterFactory
...s/kafka/producer/src/main/java/org/opennms/features/kafka/producer/KafkaProducerManager.java
Outdated
Show resolved
Hide resolved
cgorantla
reviewed
Dec 3, 2025
Contributor
cgorantla
left a comment
cgorantla
left a comment
There was a problem hiding this comment.
We need to have a end-to-end test that actually sends messages to different Kafka clusters.
...er/src/main/java/org/opennms/features/kafka/producer/collection/KafkaPersisterActivator.java
Outdated
Show resolved
Hide resolved
...s/kafka/producer/src/main/java/org/opennms/features/kafka/producer/KafkaProducerManager.java
Outdated
Show resolved
Hide resolved
...ucer/src/main/java/org/opennms/features/kafka/producer/collection/KafkaPersisterFactory.java
Outdated
Show resolved
Hide resolved
...s/kafka/producer/src/main/java/org/opennms/features/kafka/producer/KafkaProducerManager.java
Outdated
Show resolved
Hide resolved
cgorantla
reviewed
Dec 5, 2025
Contributor
cgorantla
left a comment
cgorantla
left a comment
There was a problem hiding this comment.
Please take care of all review comments including adding a integration test.
...ucer/src/main/java/org/opennms/features/kafka/producer/collection/KafkaPersisterFactory.java
Outdated
Show resolved
Hide resolved
...s/kafka/producer/src/main/java/org/opennms/features/kafka/producer/KafkaProducerManager.java
Outdated
Show resolved
Hide resolved
...s/kafka/producer/src/main/java/org/opennms/features/kafka/producer/KafkaProducerManager.java
Outdated
Show resolved
Hide resolved
cgorantla
requested changes
Dec 8, 2025
Contributor
cgorantla
left a comment
cgorantla
left a comment
There was a problem hiding this comment.
I tested this and this doesn't work. Removing initialization of producer in KafkaProducerManager#init helped.
...s/kafka/producer/src/main/java/org/opennms/features/kafka/producer/KafkaProducerManager.java
Show resolved
Hide resolved
...s/kafka/producer/src/main/java/org/opennms/features/kafka/producer/KafkaProducerManager.java
Outdated
Show resolved
Hide resolved
cgorantla
reviewed
Dec 23, 2025
...ucer/src/main/java/org/opennms/features/kafka/producer/collection/KafkaPersisterFactory.java
Outdated
Show resolved
Hide resolved
...s/kafka/producer/src/main/java/org/opennms/features/kafka/producer/KafkaProducerManager.java
Outdated
Show resolved
Hide resolved
...s/kafka/producer/src/main/java/org/opennms/features/kafka/producer/KafkaProducerManager.java
Outdated
Show resolved
Hide resolved
features/kafka/producer/src/main/java/org/opennms/features/kafka/producer/NoOpProducer.java
Outdated
Show resolved
Hide resolved
...s/kafka/producer/src/main/java/org/opennms/features/kafka/producer/KafkaProducerManager.java
Outdated
Show resolved
Hide resolved
...s/kafka/producer/src/main/java/org/opennms/features/kafka/producer/KafkaProducerManager.java
Outdated
Show resolved
Hide resolved
...s/kafka/producer/src/main/java/org/opennms/features/kafka/producer/KafkaProducerManager.java
Outdated
Show resolved
Hide resolved
features/kafka/producer/src/test/java/org/opennms/features/kafka/producer/KafkaForwarderIT.java
Outdated
Show resolved
Hide resolved
cgorantla
reviewed
Dec 24, 2025
Contributor
cgorantla
left a comment
cgorantla
left a comment
There was a problem hiding this comment.
I have tested this. Seems to work fine.
Whenever we update config at runtime, we need to stop and start the feature. This needs to be incorporated into the doc.
Member
|
I have tested it and working as expected |
cgorantla
reviewed
Dec 29, 2025
Contributor
cgorantla
left a comment
cgorantla
left a comment
There was a problem hiding this comment.
Few comments to cleanup otherwise LGTM
...er/src/main/java/org/opennms/features/kafka/producer/collection/KafkaPersisterActivator.java
Show resolved
Hide resolved
...ucer/src/main/java/org/opennms/features/kafka/producer/collection/KafkaPersisterFactory.java
Outdated
Show resolved
Hide resolved
...s/kafka/producer/src/main/java/org/opennms/features/kafka/producer/KafkaProducerManager.java
Outdated
Show resolved
Hide resolved
features/kafka/producer/src/main/java/org/opennms/features/kafka/producer/NoOpProducer.java
Outdated
Show resolved
Hide resolved
features/kafka/producer/src/main/resources/OSGI-INF/blueprint/blueprint-kafka-producer.xml
Outdated
Show resolved
Hide resolved
features/kafka/producer/src/main/resources/OSGI-INF/blueprint/blueprint-kafka-producer.xml
Outdated
Show resolved
Hide resolved
features/kafka/producer/src/main/resources/OSGI-INF/blueprint/blueprint-kafka-producer.xml
Outdated
Show resolved
Hide resolved
...ucer/src/main/java/org/opennms/features/kafka/producer/collection/KafkaPersisterFactory.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable Kafka Producer to sent separate topics to different Kafka Servers, IE: Alarms get to sent to one set of kafka servers, events to another set, metrics to another set.