refactor: update PUBLIC_SKILLS_REPO to OpenHands/extensions#2085
refactor: update PUBLIC_SKILLS_REPO to OpenHands/extensions#2085
Conversation
Update all references from OpenHands/skills to OpenHands/extensions to support the repository rename. Changes: - Update PUBLIC_SKILLS_REPO constant in skill.py - Update documentation and examples - Update agent_context.py load_public_skills description - Update skills_router.py and skills_service.py comments - Update tests This change should be merged AFTER the skills repo is renamed to OpenHands/extensions. GitHub redirects will handle the transition period. Related PRs: - OpenHands/skills#50: Prepare for rename to OpenHands/extensions - OpenHands/docs: Update documentation URLs (pending) Co-authored-by: openhands <openhands@all-hands.dev>
Update all documentation references from OpenHands/skills to OpenHands/extensions to support the repository rename. Updated files: - overview/skills.mdx - overview/skills/public.mdx - overview/skills/keyword.mdx - overview/skills/repo.mdx - sdk/guides/skill.mdx - sdk/guides/github-workflows/pr-review.mdx - openhands/usage/use-cases/code-review.mdx Related PRs: - OpenHands/skills#50: Prepare for rename to OpenHands/extensions - OpenHands/software-agent-sdk#2085: Update PUBLIC_SKILLS_REPO URL Co-authored-by: openhands <openhands@all-hands.dev>
Update test comment reference from OpenHands/skills to OpenHands/extensions to match the repository rename. Related PRs: - OpenHands/skills#50: Prepare for rename to OpenHands/extensions - OpenHands/software-agent-sdk#2085: Update PUBLIC_SKILLS_REPO URL - OpenHands/docs#337: Update documentation URLs Co-authored-by: openhands <openhands@all-hands.dev>
Coverage Report •
|
||||||||||||||||||||||||||||||||||||||||
The change to PUBLIC_SKILLS_REPO URL description is detected as an API change by Griffe. Bump minor version to satisfy API breakage check. Co-authored-by: openhands <openhands@all-hands.dev>
all-hands-bot
left a comment
There was a problem hiding this comment.
LGTM! The refactoring is comprehensive and consistent across all references.
Quick question: Is the MINOR bump (1.11.4 → 1.12.0) intentional? Since this is just a URL update (with GitHub redirects handling backward compat), I'd expect a PATCH bump (1.11.5). But maybe there are other changes planned for 1.12.0 or you're treating the repo rename as significant enough for MINOR? 🤔
The code changes themselves look great - ready to merge after the skills→extensions repo rename is complete! ✨
all-hands-bot
left a comment
There was a problem hiding this comment.
LGTM! Clean and complete refactoring. 🚀
All references updated consistently across code, docs, examples, and tests. Backward compatibility maintained via GitHub redirects.
The MINOR bump (1.11.4 → 1.12.0) was already questioned by @all-hands-bot - I'd also expect PATCH for a URL update, but it's not a blocker. If there's a reason for MINOR (maybe treating this as a "user-facing change" since the description field changed?), that's fine.
Ready to merge once the OpenHands/skills repo is renamed! ✨
Summary
Update all references from
OpenHands/skillstoOpenHands/extensionsto support the repository rename.Changes
PUBLIC_SKILLS_REPOconstant inskill.pyfromhttps://github.com/OpenHands/skillstohttps://github.com/OpenHands/extensionsagent_context.pyload_public_skills descriptionskills_router.pyandskills_service.pycommentsFiles Changed
openhands-sdk/openhands/sdk/context/skills/skill.pyPUBLIC_SKILLS_REPOURL constantopenhands-sdk/openhands/sdk/context/agent_context.pyopenhands-agent-server/openhands/agent_server/skills_router.pyopenhands-agent-server/openhands/agent_server/skills_service.pyexamples/01_standalone_sdk/03_activate_skill.pyexamples/03_github_workflows/02_pr_review/README.mdexamples/03_github_workflows/02_pr_review/agent_script.pytests/sdk/context/skill/test_load_public_skills.pyMerge Order
OpenHands/extensions.GitHub redirects will handle the transition period, so there's no risk of breakage:
https://github.com/OpenHands/extensionswon't work, but tests will fail clearlyOpenHands/skills→OpenHands/extensionsRelated PRs
Testing
Tests should pass once the repository is renamed. Before the rename, tests referencing the new URL will fail (expected behavior).
@neubig can click here to continue refining the PR
Agent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.12-nodejs22golang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:9675f55-pythonRun
All tags pushed for this build
About Multi-Architecture Support
9675f55-python) is a multi-arch manifest supporting both amd64 and arm649675f55-python-amd64) are also available if needed