feat(llm): add Kimi K2.5 to verified models#1907
feat(llm): add Kimi K2.5 to verified models#1907juanmichelini wants to merge 2 commits intoOpenHands:mainfrom
Conversation
Add kimi-k2.5 to VERIFIED_OPENHANDS_MODELS to make it available in the OpenHands provider interface. The model already has proper feature configuration in model_features.py: - send_reasoning_content support - default temperature of 1.0 Added comprehensive tests for kimi-k2.5: - Send reasoning content support - Default temperature configuration Related to OpenHands/OpenHands#12709 Addresses OpenHands/OpenHands#12730 Co-authored-by: openhands <[email protected]>
all-hands-bot
left a comment
all-hands-bot
left a comment
There was a problem hiding this comment.
Code looks solid! The model is correctly added to verified models and feature configuration is already in place. One minor suggestion for test consistency.
| ("Kimi-K2-Thinking", True), # Case insensitive | ||
| ("moonshot/kimi-k2-thinking", True), # With provider prefix | ||
| ("kimi-k2.5", True), | ||
| ("Kimi-K2.5", True), # Case insensitive |
There was a problem hiding this comment.
🟡 Suggestion: Consider adding provider prefix test cases for consistency with kimi-k2-thinking tests.
kimi-k2-thinking has tests like "moonshot/kimi-k2-thinking" (line 296), but kimi-k2.5 only has the base name and case-insensitive variant. Adding provider prefix tests would ensure the pattern matching works consistently across different deployment scenarios.
| ("Kimi-K2.5", True), # Case insensitive | |
| ("Kimi-K2.5", True), # Case insensitive | |
| ("moonshot/kimi-k2.5", True), # With provider prefix |
| ("litellm_proxy/kimi-k2-thinking", 1.0), # With litellm proxy prefix | ||
| # kimi-k2.5 models should also default to 1.0 | ||
| ("kimi-k2.5", 1.0), | ||
| ("Kimi-K2.5", 1.0), # Case insensitive |
There was a problem hiding this comment.
🟡 Suggestion: Add provider prefix test cases here too for consistency.
kimi-k2-thinking tests include both moonshot/ and litellm_proxy/ prefixes (lines 324-325). Consider adding similar tests for kimi-k2.5:
| ("Kimi-K2.5", 1.0), # Case insensitive | |
| ("Kimi-K2.5", 1.0), # Case insensitive | |
| ("moonshot/kimi-k2.5", 1.0), # With provider prefix | |
| ("litellm_proxy/kimi-k2.5", 1.0), # With litellm proxy prefix |
2 participants
Add kimi-k2.5 to VERIFIED_OPENHANDS_MODELS to make it available in the OpenHands provider interface.
Changes
kimi-k2.5toVERIFIED_OPENHANDS_MODELSThe model already has proper feature configuration in model_features.py:
Related Issues
Note
This PR provides the SDK-level support for Kimi K2.5. The existing PR OpenHands/OpenHands#12730 adds support at the OpenHands V0 level, but V1 (current) uses the SDK for model configuration.