Skip to content

Update code-review skill with repo-specific approval guidelines#1904

Open
xingyaoww wants to merge 2 commits intomainfrom
update-code-review-skill-approval-guidelines
Open

Update code-review skill with repo-specific approval guidelines#1904
xingyaoww wants to merge 2 commits intomainfrom
update-code-review-skill-approval-guidelines

Conversation

@xingyaoww
Copy link
Collaborator

@xingyaoww xingyaoww commented Feb 4, 2026

Summary

Updates the .openhands/skills/code-review.md to be a repo-specific code review guideline for OpenHands/software-agent-sdk with explicit approval permissions.

Key changes:

  • Position the skill as OpenHands/software-agent-sdk specific guidelines
  • Add "Review Decisions" section defining when the bot can APPROVE vs COMMENT
  • Remove REQUEST_CHANGES ability—let human maintainers decide whether to block PRs
  • Define clear criteria for approval: config changes, cosmetic fixes, simple additions, test-only changes, dependency updates
  • Define when to comment: issues needing attention, suggestions, questions, style preferences

This enables the AI reviewer to approve straightforward PRs (like adding a new model to config files) while leaving blocking decisions to human maintainers.

Checklist

  • If the PR is changing/adding functionality, are there tests to reflect this?
    • N/A: This is a documentation/skill file change
  • If there is an example, have you run the example to make sure that it works?
    • N/A: No code examples affected
  • If there are instructions on how to run the code, have you followed the instructions and made sure that it works?
    • N/A: No runnable code changed
  • If the feature is significant enough to require documentation, is there a PR open on the OpenHands/docs repository with the same branch name?
    • N/A: Internal skill configuration
  • Is the github CI passing?

@xingyaoww can click here to continue refining the PR


Agent Server images for this PR

GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server

Variants & Base Images

Variant Architectures Base Image Docs / Tags
java amd64, arm64 eclipse-temurin:17-jdk Link
python amd64, arm64 nikolaik/python-nodejs:python3.13-nodejs22 Link
golang amd64, arm64 golang:1.21-bookworm Link

Pull (multi-arch manifest)

# Each variant is a multi-arch manifest supporting both amd64 and arm64
docker pull ghcr.io/openhands/agent-server:865e7cc-python

Run

docker run -it --rm \
  -p 8000:8000 \
  --name agent-server-865e7cc-python \
  ghcr.io/openhands/agent-server:865e7cc-python

All tags pushed for this build

ghcr.io/openhands/agent-server:865e7cc-golang-amd64
ghcr.io/openhands/agent-server:865e7cc-golang_tag_1.21-bookworm-amd64
ghcr.io/openhands/agent-server:865e7cc-golang-arm64
ghcr.io/openhands/agent-server:865e7cc-golang_tag_1.21-bookworm-arm64
ghcr.io/openhands/agent-server:865e7cc-java-amd64
ghcr.io/openhands/agent-server:865e7cc-eclipse-temurin_tag_17-jdk-amd64
ghcr.io/openhands/agent-server:865e7cc-java-arm64
ghcr.io/openhands/agent-server:865e7cc-eclipse-temurin_tag_17-jdk-arm64
ghcr.io/openhands/agent-server:865e7cc-python-amd64
ghcr.io/openhands/agent-server:865e7cc-nikolaik_s_python-nodejs_tag_python3.13-nodejs22-amd64
ghcr.io/openhands/agent-server:865e7cc-python-arm64
ghcr.io/openhands/agent-server:865e7cc-nikolaik_s_python-nodejs_tag_python3.13-nodejs22-arm64
ghcr.io/openhands/agent-server:865e7cc-golang
ghcr.io/openhands/agent-server:865e7cc-java
ghcr.io/openhands/agent-server:865e7cc-python

About Multi-Architecture Support

  • Each variant tag (e.g., 865e7cc-python) is a multi-arch manifest supporting both amd64 and arm64
  • Docker automatically pulls the correct architecture for your platform
  • Individual architecture tags (e.g., 865e7cc-python-amd64) are also available if needed

- Position skill as OpenHands/software-agent-sdk specific guidelines
- Add Review Decisions section with APPROVE and COMMENT permissions
- Remove REQUEST_CHANGES ability (let human maintainers block PRs)
- Define when to approve: config changes, cosmetic fixes, simple additions
- Define when to comment: issues, suggestions, questions

Co-authored-by: openhands <[email protected]>
@xingyaoww xingyaoww marked this pull request as ready for review February 4, 2026 15:43
Copy link
Collaborator

@all-hands-bot all-hands-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent documentation update! This PR provides clear, actionable guidelines for AI code reviews specific to this repository.

Key Strengths

Clear structure: The distinction between APPROVE and COMMENT is well-defined
Sensible approach: Removing REQUEST_CHANGES and letting human maintainers make blocking decisions
Concrete example: The resolve_model_config.py example helps make the guidelines actionable
Preserves existing content: Core principles and style guidelines remain intact

Minor Suggestions

🟡 Line 14: Consider adding a brief rationale for not using REQUEST_CHANGES:

"Do not use REQUEST_CHANGES - let human maintainers make final blocking decisions."

🟢 Line 20: The "updating CI/workflow settings" criterion is quite broad. Some CI changes (like deployment pipelines) might be higher risk than others (like adding linters). This may be intentional given the repo context, but worth noting.

Summary

This is a straightforward, low-risk documentation improvement that makes the code-review skill more effective for this repository. Approving per the guidelines established in the PR itself! 🚀

@xingyaoww xingyaoww requested review from enyst, neubig and rbren February 4, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants