Update code-review skill with repo-specific approval guidelines#1904
Update code-review skill with repo-specific approval guidelines#1904
Conversation
- Position skill as OpenHands/software-agent-sdk specific guidelines - Add Review Decisions section with APPROVE and COMMENT permissions - Remove REQUEST_CHANGES ability (let human maintainers block PRs) - Define when to approve: config changes, cosmetic fixes, simple additions - Define when to comment: issues, suggestions, questions Co-authored-by: openhands <[email protected]>
all-hands-bot
left a comment
There was a problem hiding this comment.
Excellent documentation update! This PR provides clear, actionable guidelines for AI code reviews specific to this repository.
Key Strengths
✅ Clear structure: The distinction between APPROVE and COMMENT is well-defined
✅ Sensible approach: Removing REQUEST_CHANGES and letting human maintainers make blocking decisions
✅ Concrete example: The resolve_model_config.py example helps make the guidelines actionable
✅ Preserves existing content: Core principles and style guidelines remain intact
Minor Suggestions
🟡 Line 14: Consider adding a brief rationale for not using REQUEST_CHANGES:
"Do not use REQUEST_CHANGES - let human maintainers make final blocking decisions."
🟢 Line 20: The "updating CI/workflow settings" criterion is quite broad. Some CI changes (like deployment pipelines) might be higher risk than others (like adding linters). This may be intentional given the repo context, but worth noting.
Summary
This is a straightforward, low-risk documentation improvement that makes the code-review skill more effective for this repository. Approving per the guidelines established in the PR itself! 🚀
Summary
Updates the
.openhands/skills/code-review.mdto be a repo-specific code review guideline for OpenHands/software-agent-sdk with explicit approval permissions.Key changes:
This enables the AI reviewer to approve straightforward PRs (like adding a new model to config files) while leaving blocking decisions to human maintainers.
Checklist
@xingyaoww can click here to continue refining the PR
Agent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.13-nodejs22golang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:865e7cc-pythonRun
All tags pushed for this build
About Multi-Architecture Support
865e7cc-python) is a multi-arch manifest supporting both amd64 and arm64865e7cc-python-amd64) are also available if needed