Conversation
all-hands-bot
left a comment
There was a problem hiding this comment.
Found two issues with the license change that should be addressed before merging.
| MIT License | ||
|
|
||
| Copyright (c) 2025 All Hands AI | ||
| Copyright (c) 2026 OpenHands contributors |
There was a problem hiding this comment.
🟠 Important: The year is set to 2026, but we are currently in 2025. Copyright years should reflect either:
- The year of first publication
- A range from first publication to current year (e.g., "2024-2025")
- The current year (2025)
Setting a future year (2026) is unconventional and potentially misleading.
| Copyright (c) 2026 OpenHands contributors | |
| Copyright (c) 2025 OpenHands contributors |
There was a problem hiding this comment.
we are currently in 2025
😂
| MIT License | ||
|
|
||
| Copyright (c) 2025 All Hands AI | ||
| Copyright (c) 2026 OpenHands contributors |
There was a problem hiding this comment.
🟡 Suggestion: Consider whether "OpenHands contributors" is the intended copyright holder. While common for open-source projects, you may want to verify:
- Is there a legal entity (All Hands AI) that should retain copyright?
- Should this use a range starting from the project's inception year?
- Does this align with your contribution guidelines and CLA (if any)?
The format itself is fine, but ensure this change has been approved by the appropriate stakeholders.
There was a problem hiding this comment.
Yes, it's fine, Claude dear.
|
Can you please add a unit test? |
Sorry, for what? |
just kidding, sorry |
This PR proposes a tiny tweak to the license. I think the agent claimed AH copyright and we didn't notice.
To clarify, whatever is written here doesn't actually matter, it's not like legally it'd give AH copyright when it doesn't have it nor the other way around. I just think maybe it may matter occasionally for people reading it, and / or humans' understanding in general. In other words, the text has a very different goal than any "legal" goal.
Agent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.13-nodejs22golang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:a042f5b-pythonRun
All tags pushed for this build
About Multi-Architecture Support
a042f5b-python) is a multi-arch manifest supporting both amd64 and arm64a042f5b-python-amd64) are also available if needed