Add sumDouble, sumLong, sumBigDecimal, and sumBigInteger to NumberExpression for forward compatibility with Querydsl 6+#1641
Open
jparams wants to merge 6 commits intoOpenFeign:querydsl-5.0.0from
Open
Conversation
…,-sumbiginteger-methods Add sumDouble, sumLong, sumBigDecimal, and sumBigInteger to NumberExpression for forward compatibility with Querydsl 6+
…,-sumbiginteger-methods-4mv7xt
…,-sumbiginteger-methods-4mv7xt Add typed sum aggregation methods to NumberExpression
Author
|
Hi, just checking in to see what the likelihood of getting this merged in is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the following typed aggregation helpers to
NumberExpression:sumDouble()sumLong()sumBigDecimal()sumBigInteger()Motivation
Querydsl 6+ introduces typed aggregation helpers such as
sumDouble()andsumLong().Adding these methods to Querydsl 5 allows projects to adopt the newer DSL now and makes future upgrades easier.
This provides forward compatibility and reduces code changes required when migrating to newer versions.
Example