Add Patina Config Enforcement#1324
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
7ba501c to
76a19e1
Compare
Per RFC 25, this patch adds config.toml enforcement of the Patina config version. config.toml is updated to reflect the various settings Patina wants to use. Each is documented on why. build.rs verifies the patina config version is the correct one and will fail the build if not. Docs are updated. Signed-off-by: Oliver Smith-Denny <osde@microsoft.com>
QEMU Validation FailedQEMU validation did not complete successfully or did not shutdown as expected. Workflow run: https://github.com/OpenDevicePartnership/patina/actions/runs/22462836359 Job Results
Error Details
|
This failed due to a QEMU infra bug: ERROR:../../../block/vvfat.c:2429:commit_direntries: assertion failed: (mapping) |
In case others come across this, it's been an issue on Windows hosts for a while. Now being tracked here to resolve for patina-qemu: OpenDevicePartnership/patina-qemu#188 |
Description
Per RFC 25, this patch adds config.toml enforcement of the Patina config version.
config.toml is updated to reflect the various settings Patina wants to use. Each is documented on why.
build.rs verifies the patina config version is the correct one and will fail the build if not.
Docs are updated.
Note this targets the major branch.
How This Was Tested
Tested building Q35 and SBSA and booting them to Windows. Settings were validated in build.rs and by outside factors such as binary size.
Integration Instructions
Patina's
.cargo/config.tomlmust be copied to the platform's.cargo/config.toml. See the docs for more details.