Skip to content

ec-test-app: Add serial source#38

Merged
kurtjd merged 1 commit intoOpenDevicePartnership:mainfrom
kurtjd:add-serial-source
Feb 25, 2026
Merged

ec-test-app: Add serial source#38
kurtjd merged 1 commit intoOpenDevicePartnership:mainfrom
kurtjd:add-serial-source

Conversation

@kurtjd
Copy link
Contributor

@kurtjd kurtjd commented Jan 20, 2026

This PR does a few things:

  • Adds serial as a Source, which allows the app to talk directly to a dev platform in user-space (over a COM port for example). Can be useful for testing services without needing to worry about FFA and whatnot.
  • Fixes some clippy warnings introduced from needing to bump MSRV
  • Some minor refactoring to use the message structs defined by the crates in embedded-services

Tested this on the dev-imxrt platform and works pretty well.

Can run with:
cargo run --release --features serial <COM#> none [baud]

Baud rate is an optional argument and can be omitted since I have it set to default to 115200 which the dev platforms use.

@kurtjd kurtjd self-assigned this Jan 20, 2026
@kurtjd kurtjd added the enhancement New feature or request label Jan 20, 2026
@kurtjd kurtjd moved this to In review in ODP Backlog Jan 20, 2026
philgweber
philgweber previously approved these changes Jan 20, 2026
Copy link
Contributor

@philgweber philgweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will have to think about the transport and integrating with FFA and secure world so we have the ability to redirect messages through either path.

@kurtjd
Copy link
Contributor Author

kurtjd commented Jan 20, 2026

Will have to think about the transport and integrating with FFA and secure world so we have the ability to redirect messages through either path.

So I was thinking this can be used as an alternative to going through FFA when someone jsut wants to quickly connect to a board and do some testing of the services. In my mind I imagined this app will just select the acpi source if it wants to talk to FFA, and whether FFA goes through uart or eSPI from the apps perspective shouldn't matter. Does that seem similar to what you were thinking?

@kurtjd kurtjd changed the title Add serial source ec-test-app: Add serial source Jan 20, 2026
@kurtjd kurtjd force-pushed the add-serial-source branch from 72c2645 to 75bdfa4 Compare January 20, 2026 19:24
@kurtjd kurtjd marked this pull request as ready for review January 20, 2026 19:25
@kurtjd kurtjd requested a review from a team as a code owner January 20, 2026 19:25
@kurtjd kurtjd force-pushed the add-serial-source branch from 75bdfa4 to 00a491e Compare January 20, 2026 19:39
williampMSFT
williampMSFT previously approved these changes Jan 29, 2026
Copy link
Contributor

@williampMSFT williampMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kurtjd
Copy link
Contributor Author

kurtjd commented Jan 29, 2026

Will wait for #41 to merge, then update this PR to implement RtcSource for serial.

@kurtjd
Copy link
Contributor Author

kurtjd commented Feb 11, 2026

Updated to include Time and Alarm Service since #41 was merged.

williampMSFT
williampMSFT previously approved these changes Feb 14, 2026
jerrysxie
jerrysxie previously approved these changes Feb 19, 2026
@kurtjd
Copy link
Contributor Author

kurtjd commented Feb 25, 2026

@jerrysxie @tullom Please review when you have a chance

Copy link
Contributor

@tullom tullom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the ping, tested this with the rt685 evk board and the data was updating! Great job with this!

@kurtjd
Copy link
Contributor Author

kurtjd commented Feb 25, 2026

Thank you for the ping, tested this with the rt685 evk board and the data was updating! Great job with this!

Thank you! :)

@kurtjd kurtjd merged commit cbeedcf into OpenDevicePartnership:main Feb 25, 2026
@github-project-automation github-project-automation bot moved this from In review to Done in ODP Backlog Feb 25, 2026
@kurtjd kurtjd deleted the add-serial-source branch February 25, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants