fix(php-symfony): enum $ref query params — short types and imports (#23521)#23525
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Apr 14, 2026
Merged
Conversation
…imports * Normalize dotted / flattened enum-ref dataType and resync operation imports; rebuild OperationsMap imports after postProcess for api.mustache use lines * Unify api.mustache @param and signatures on vendorExtensions.x-parameter-type (short name + optional|null) for isEnumRef * Add OAS 3.1 petstore fixture under 3_1/php-symfony and extend PhpSymfonyServerCodegenTest (PHPDoc + php -l) * Document normalizeEnumRefParameterDataType / sync / refresh import pipeline
Member
|
thanks for the PR which has been merged |
Contributor
Author
|
不谢 我在使用中还发现了几个关于 enum 的问题和关于 Controller 代码生成的问题 后续再提 PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #23521
Summary
php-symfony: fix enum-by-reference query parameters (
components.parameters→ schema$refto string enum) soDefaultApiInterfaceuses short class names anduseimports that match the generated model, instead of stitched / double-modelPackagetype strings.See #23521 (wrong FQCN / import for
$refenum query params inDefaultApiInterface).Changes
PhpSymfonyServerCodegen:normalizeEnumRefParameterDataType→syncEnumRefOperationImports→ after all operations,refreshAggregatedImportsForOperationssodataTypeis the short PHP model name andOperationsMapimports match Mustache.api.mustache: parameter PHPDoc and signatures usevendorExtensions.x-parameter-typefor all params (includingisEnumRef); enum refs getx-parameter-typeviagetTypeHint(modelPackage + "\\" + dataType, false)when needed.modules/openapi-generator/src/test/resources/3_1/php-symfony/petstore-dotted-enum-ref-query-param-component.yaml+PhpSymfonyServerCodegenTest(shortuse, short type hint,@paramshape; whenphpis onPATH,php -lon generatedDefaultApiInterface.php).postProcessOperationsWithModels.How to validate
Build / samples / docs (per contribution checklist)
Local run with Java 11 (
JAVA_HOME=/opt/homebrew/opt/openjdk@11/libexec/openjdk.jdk/Contents/Home, OpenJDK 11.0.30):All three commands completed successfully; sample batch reported 741 configs successful. All generated / updated files from these commands are included in this PR.
cc PHP committee: @jebentier @dkarlovi @mandrean @jfastnacht @ackintosh @ybelenko @renepardon
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release — breaking changes with fallbacks). (If you opened against8.0.xinstead, edit this line accordingly.)"fixes #123"present in the PR description)Summary by cubic
Fixes #23521. Corrects enum-by-reference query params in
php-symfonysoDefaultApiInterfaceuses short enum class names with properuseimports, avoiding stitched or flattenedmodelPackagetokens.isEnumRefparamdataTypeto the short model class and resync per-operation imports; rebuild aggregated imports for accurateuselines.api.mustacheto usevendorExtensions.x-parameter-typefor all params so type hints and@paramuse the short enum name.api_controller.mustacheandapi_input_validation.mustacheto build FQCNs as\{modelPackage}\{dataType}with correct escaping.useimport, short type hint inDefaultApiInterface, andphp -lpasses.Written for commit 8def2cb. Summary will update on new commits.