[java] Support 'date-time-local' format#23395
Open
Allsimon wants to merge 2 commits intoOpenAPITools:masterfrom
Open
[java] Support 'date-time-local' format#23395Allsimon wants to merge 2 commits intoOpenAPITools:masterfrom
Allsimon wants to merge 2 commits intoOpenAPITools:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractJavaCodegen.java">
<violation number="1" location="modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractJavaCodegen.java:2661">
P2: New format handling uses mismatched keys (`date-time-local` vs `local-date`), so the added `date-time-local` property post-processing branch will not execute.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
.../openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractJavaCodegen.java
Outdated
Show resolved
Hide resolved
Chrimle
suggested changes
Mar 30, 2026
.../openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractJavaCodegen.java
Show resolved
Hide resolved
Chrimle
approved these changes
Mar 30, 2026
modules/openapi-generator/src/test/resources/3_0/spring/date-time-local.yml
Outdated
Show resolved
Hide resolved
.../openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractJavaCodegen.java
Show resolved
Hide resolved
.../openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractJavaCodegen.java
Show resolved
Hide resolved
Member
|
https://github.com/OpenAPITools/openapi-generator/actions/runs/23816722621/job/69487441944?pr=23395 please update the samples to fix this |
Chrimle
suggested changes
Apr 1, 2026
samples/client/petstore/spring-cloud-date-time/src/main/java/org/openapitools/model/Pet.java
Outdated
Show resolved
Hide resolved
...penapi3/client/petstore/spring-cloud-date-time/src/main/java/org/openapitools/model/Pet.java
Outdated
Show resolved
Hide resolved
b5c45a8 to
c33bc7f
Compare
Contributor
There was a problem hiding this comment.
1 issue found across 7 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractJavaCodegen.java">
<violation number="1" location="modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractJavaCodegen.java:1417">
P2: `date-time-local` default generation is incorrectly limited to `dateLibrary=java8`, so `java8-localdatetime` silently loses declared defaults.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
.../openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractJavaCodegen.java
Show resolved
Hide resolved
This test is weird: since fd45b74 it only test the .toString() method...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://spec.openapis.org/registry/format/date-time-local.html
fixes #13889
@cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08)
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Add support for the OpenAPI
date-time-localformat in the Java/Spring generator. Maps toLocalDateTime(java.time.LocalDateTime) and parses defaults when thejava8date library is used; fixes #13889.date-time-local→LocalDateTimein AbstractJavaCodegen; always importjava.time.LocalDateTime; addModelUtils.isDateTimeLocalSchema.date-time-localdefaults viaLocalDateTime.parse(...)for thejava8date library (including nested object property defaults); add unit tests (Java + Spring), fix a broken test, and regenerate samples (Pet.adoptionDatewith default).Written for commit b2f0560. Summary will update on new commits.