Skip to content

17 situation as supercategory for state and process#18

Open
AlexU75 wants to merge 27 commits intomainfrom
17-situation-as-supercategory-for-state-and-process
Open

17 situation as supercategory for state and process#18
AlexU75 wants to merge 27 commits intomainfrom
17-situation-as-supercategory-for-state-and-process

Conversation

@AlexU75
Copy link
Contributor

@AlexU75 AlexU75 commented Sep 29, 2025

No description provided.

@AlexU75 AlexU75 self-assigned this Sep 29, 2025
@AlexU75 AlexU75 linked an issue Sep 29, 2025 that may be closed by this pull request
@KonradHoeffner
Copy link
Contributor

The automatic check fails because the imported GFO core ontology https://onto-med.github.io/gfo-light/gfo-core/2025-10-01/gfo-core.owl cannot be found, is this related to the PR or should I open a separate issue? I'm not sure how that file is supposed to be published there after looking at the GitHub action for the release.

Copy link
Contributor

@KonradHoeffner KonradHoeffner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could successfully load it in Protégé after resolving the missing import and it looks good to me but I'm not a GFO expert.
Can you clarify how to input is supposed to work?
https://w3id.org/gfo-core/release/2025-10-01 resolves to https://onto-med.github.io/gfo-light/gfo-core/2025-10-01/gfo-core.owl which does not exist, will that be automatically created once this PR is merged?

@ChristophB
Copy link
Member

ChristophB commented Sep 30, 2025

The automatic check fails because the imported GFO core ontology https://onto-med.github.io/gfo-light/gfo-core/2025-10-01/gfo-core.owl cannot be found, is this related to the PR or should I open a separate issue? I'm not sure how that file is supposed to be published there after looking at the GitHub action for the release.

The file is published to that location once a release has been created. However, the test tries to load the imported ontology remotely, before a release.

robot report is used in the test and there is no way to specify import locations other than by providing a catalog-v001.xml file. This means that the XML file must be updated whenever gfo-core is modified in a pull request. Unfortunately, I am not aware of an elegant way to overcome this issue.

@KonradHoeffner
Copy link
Contributor

From the point of view of a domain expert that wants to update their domain ontology fundation, I think it would be really helpful to give a short migration guide so that one can see at a glance, whether one has to update anything or not.
To that end I added a revision history section to the README, feel free to check this for correctness and completeness and maybe add a sentence on whether and if yes what a user has to change.

@KonradHoeffner
Copy link
Contributor

I really like the changelog as a a separate file. Now it doesn't clutter the README and gives actionable migration advice.

Copy link
Contributor

@KonradHoeffner KonradHoeffner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have Arial on my system but it still looks correct on both Firefox Developer Edition 146.0b9 (64-bit), Eye of Gnome and Inkscape, so it seems to have some adequate fallback mechanism even though I can't figure out which font it is actually using.

Image

@KonradHoeffner
Copy link
Contributor

KonradHoeffner commented Dec 15, 2025

Firefox falls back to NimbusSans-Regular, fc-match Arial returns LiberationSans-Regular.ttf: "Liberation Sans" "Regular".
So it seems at least on my system the lack of Arial is not a problem as both those fonts are sans serif, look similar and seem to have similar spacing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Situation as supercategory for state and process

4 participants