Rework area code to improve maintainability #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theEvilReaper
added
enhancement
Contributor
Author
|
The current state of the pull request is that the |
theEvilReaper
force-pushed
the
feature/reviseGameArea
branch
from
92839a9 to
42e6987
Compare
# Conflicts: # common/src/main/java/net/theevilreaper/tamias/common/map/GameMap.java # common/src/main/java/net/theevilreaper/tamias/common/map/MapPool.java # common/src/main/java/net/theevilreaper/tamias/common/map/MapProvider.java # game/src/main/java/net/theevilreaper/tamias/game/map/GameMapProvider.java
# Conflicts: # common/src/main/java/net/theevilreaper/tamias/common/map/GameMap.java # common/src/main/java/net/theevilreaper/tamias/common/map/MapPool.java # common/src/main/java/net/theevilreaper/tamias/common/map/MapProvider.java # game/src/main/java/net/theevilreaper/tamias/game/map/GameMapProvider.java
# Conflicts: # setup/src/main/java/net/theevilreaper/tamias/setup/data/GameData.java # setup/src/main/java/net/theevilreaper/tamias/setup/map/SetupMapProvider.java
theEvilReaper
force-pushed
the
feature/reviseGameArea
branch
from
e6882d0 to
788b17d
Compare
theEvilReaper
added a commit
that referenced
this pull request
Jul 15, 2025
* Rework area handling to reduce complexity * Rework area handling to reduce complexity * Move GroundData out of the area package * Improve documentation and maintainability * Simplify block replace * Rename FinishBuildEvent to AreaFinishBuildEvent * Remove duplicated test * Improve how the game triggers the area placement or cleanup * Add new area events * Rename test class * Improve AreCleanupEvent * Improve area tests * Move ground test to own package * Rename area data class and update usage * Improve corner block replacement check * Add option customize the calculation process of some values * Update tests * Update calculation trigger * Update method calls * Use Collection instead of a Set as return type * Update positions getter * Fix block placement * More improvements to the placement logic * Improve placement trigger * Fix some wrong code parts due to the rebase * Update triggerPlacement call * Update structure and logic from the GroundPlacement * Improve TNTPlacement logik and add test case * Add own class for the BlockAssertions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request overhauls the current implementation of the area system from the game. The current state lacks maintainability and the encapsulation is very hard. This ends in weird code usage and other things
NOTE: DON'T MERGE THIS YET