Migrate to the SetupData system from Guira #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theEvilReaper
added
enhancement
# Conflicts: # setup/src/main/java/net/theevilreaper/tamias/setup/TamiasSetup.java
theEvilReaper
force-pushed
the
feature/guira
branch
from
d5afaff to
dd39b9e
Compare
setup/src/main/java/net/theevilreaper/tamias/setup/commands/parts/SetupPositionCommand.java
Outdated
Show resolved
Hide resolved
OneLiteFeather
requested changes
Jun 17, 2025
OneLiteFeather
left a comment
OneLiteFeather
left a comment
There was a problem hiding this comment.
Looks good so far, I just have one request
TheMeinerLP
requested changes
Jun 18, 2025
Comment on lines
+93
to
+96
| manager.addListener( | ||
| (Class<SetupFinishEvent<InstanceSetupData<? extends BaseMap>>>) (Class<?>) SetupFinishEvent.class, | ||
| new SetupFinishListener(instanceSwitcher) | ||
| ); |
Contributor
There was a problem hiding this comment.
Looks complicated. Is there a better way ?
Contributor
Author
There was a problem hiding this comment.
The available options are limited. Minestom does not allow direct use of the raw event class due to its generic structure. One possible solution would be to create an additional class that sets the generic value internally, but this would require an update to Guira
setup/src/main/java/net/theevilreaper/tamias/setup/commands/parts/SetupNameCommand.java
Outdated
Show resolved
Hide resolved
setup/src/main/java/net/theevilreaper/tamias/setup/listener/item/PlayerUseItemListener.java
Outdated
Show resolved
Hide resolved
theEvilReaper
added a commit
that referenced
this pull request
Jul 15, 2025
* Add guira as new dependency * Add guira definition * Add new data implementation * Rework data structure * Update SetupData handling # Conflicts: # setup/src/main/java/net/theevilreaper/tamias/setup/TamiasSetup.java * Remove test classes * Update constructor calls * Remove BiConsumer variable and parameter usage * Cleanup imports * Improve SetupData usage * Update flag usage * Improve message when a data is not present * Cleanup imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid different approaches for game setups, we created a library called
Guira. To enhance their structure and reduce maintainability this pull request adapts the current aproach to variant fromGuira. Some calls looks cursed or not good by it's design. This could be improved over the next time