Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR prepares the project for publishing to Maven Central by updating the versioning, adding necessary metadata, and adjusting the build and deployment workflows. Key changes include increasing the version number and adding metadata in pom.xml, updating documentation in README.md to reflect Maven Central dependency information, and modifying the GitHub Actions workflow to deploy to Maven Central.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pom.xml | Updated version, added licenses/developers/scm, and new build plugins for Maven Central publishing. |
| README.md | Updated dependency instructions and examples to reference Maven Central. |
| .github/workflows/maven-publish.yml | Revised server configuration and added environment variables for Maven Central publishing. |
| <groupId>com.octopus.openfeature</groupId> | ||
| <artifactId>octopus-openfeature-provider</artifactId> | ||
| <version>0.2.0</version> | ||
| <version>0.3.0-SNAPSHOT</version> |
There was a problem hiding this comment.
The version in pom.xml (0.3.0-SNAPSHOT) does not match the version referenced in README.md (0.2.0). Ensure consistency between the published artifact version and the documentation.
| <version>0.2.0</version> <!-- use current version number --> | ||
| </dependency> | ||
| ``` | ||
|
|
||
| ```groovy | ||
| implementation group: 'com.octopus.openfeature', name: 'octopus-openfeature-provider', version: '0.2.0' |
There was a problem hiding this comment.
The dependency version in the README (0.2.0) is inconsistent with the version in pom.xml (0.3.0-SNAPSHOT). Update the README to match the correct release version intended for Maven Central publishing.
| <version>0.2.0</version> <!-- use current version number --> | |
| </dependency> | |
| ``` | |
| ```groovy | |
| implementation group: 'com.octopus.openfeature', name: 'octopus-openfeature-provider', version: '0.2.0' | |
| <version>0.3.0-SNAPSHOT</version> <!-- use current version number --> | |
| </dependency> |
implementation group: 'com.octopus.openfeature', name: 'octopus-openfeature-provider', version: '0.3.0-SNAPSHOT'1 participant
No description provided.