Resolve serialization error during check for changes#2
Merged
MJRichardson merged 2 commits intomainfrom Jun 17, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a serialization error encountered during change checks by updating the client serialization field, cleaning up outdated comments, and adjusting provider initialization in the README.
- Remove obsolete TODO comments regarding HttpClient version verification.
- Modify the serialization field’s access by making it public.
- Bump the project version and update the README to use synchronous provider initialization.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/java/com/octopus/openfeature/provider/OctopusClient.java | Removed TODO comments and updated the serialization field to public for proper deserialization. |
| pom.xml | Updated the version from 0.1.0 to 0.2.0. |
| README.md | Changed the provider initialization method from setProvider to setProviderAndWait for synchronous behavior. |
Comments suppressed due to low confidence (2)
src/main/java/com/octopus/openfeature/provider/OctopusClient.java:98
- Exposing the 'contentHash' field publicly fulfills the deserialization need; however, consider adding a comment or using proper annotations to document its intended usage and ensure clarity for future maintainers.
public byte[] contentHash;
README.md:84
- Since the method was updated to setProviderAndWait to enforce synchronous initialization, update the accompanying documentation or comments to inform users of any potential blocking behavior introduced by this change.
openFeature.setProviderAndWait(new OctopusProvider(new OctopusConfiguration("Your Octopus client identifier")));
andrewabest
approved these changes
Jun 17, 2025
andrewabest
left a comment
There was a problem hiding this comment.
Changes look as expected and discussed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1