Allow control of whether we generate output variables for S3 commands#1869
Open
david-staniec-octopus wants to merge 2 commits intomainfrom
Open
Allow control of whether we generate output variables for S3 commands#1869david-staniec-octopus wants to merge 2 commits intomainfrom
david-staniec-octopus wants to merge 2 commits intomainfrom
Conversation
david-staniec-octopus
force-pushed
the
ds/outputVariablesFlag
branch
from
97ca98d to
c7b37f8
Compare
… variables for S3 commands
david-staniec-octopus
force-pushed
the
ds/outputVariablesFlag
branch
from
c7b37f8 to
81d73a8
Compare
Jtango18
approved these changes
Apr 13, 2026
Contributor
Jtango18
left a comment
Jtango18
left a comment
There was a problem hiding this comment.
Sensible addition. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new option in the
UploadAwsS3Commandto allow the caller to disable creation of output variables. For deployments with thousands of files, this can create hundreds of thousands of output variables. For performance, the caller can choose to disable the creation of these output variables for performance purposes.This defaults to
trueto maintain the existing behaviour of creating these variables.