Skip to content

Conversation

@KaloyanTanev
Copy link
Collaborator

This PR solves 2 issues:

  1. Upon signing exits for all validators, Charon does not check if all validators are active. We are changing that to sign only exits for validators that are either queued for activation or active.
  2. Upon broadcasting exits for all validators, Charon does not check if all validators are active. We are changing that to broadcast only exits for validators that are active.

category: bug
ticket: none

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2026

Copy link
Collaborator

@pinebit pinebit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sad we don't update tests, but I assume this is because of urgency

@DiogoSantoss
Copy link
Contributor

How bad is signing exits for validators which are not active yet ? Asking because I remember we had issues with head not having the most up to date state and returning stale validator state. Although this was only occurred when asking close to the activation epoch so maybe not relevant.

@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

❌ Patch coverage is 72.72727% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.00%. Comparing base (af593ee) to head (8ae0ee2).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/exit_broadcast.go 57.14% 5 Missing and 4 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4205   +/-   ##
=======================================
  Coverage   57.00%   57.00%           
=======================================
  Files         237      237           
  Lines       30601    30623   +22     
=======================================
+ Hits        17443    17456   +13     
  Misses      10938    10938           
- Partials     2220     2229    +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@OisinKyne
Copy link
Contributor

OisinKyne commented Jan 6, 2026

How bad is signing exits for validators which are not active yet ?

You cannot sign a valid exit for a validator until it has an index assigned (meaning its in the activation queue at least). You cannot broadcast a valid exit until the validator has been active for at least 27 hours.

@KaloyanTanev KaloyanTanev added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jan 6, 2026
@obol-bulldozer obol-bulldozer bot merged commit b844787 into main Jan 6, 2026
11 of 12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the kalo/exit-all-inactive-vals branch January 6, 2026 13:10
KaloyanTanev added a commit that referenced this pull request Jan 6, 2026
This PR solves 2 issues:
1. Upon signing exits for all validators, Charon does not check if all validators are active. We are changing that to sign only exits for validators that are either queued for activation or active.
2. Upon broadcasting exits for all validators, Charon does not check if all validators are active. We are changing that to broadcast only exits for validators that are active.

category: bug
ticket: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge when ready Indicates bulldozer bot may merge when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants