-
Notifications
You must be signed in to change notification settings - Fork 134
cmd: skip inactive validators in exits #4205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
pinebit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sad we don't update tests, but I assume this is because of urgency
|
How bad is signing exits for validators which are not active yet ? Asking because I remember we had issues with |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4205 +/- ##
=======================================
Coverage 57.00% 57.00%
=======================================
Files 237 237
Lines 30601 30623 +22
=======================================
+ Hits 17443 17456 +13
Misses 10938 10938
- Partials 2220 2229 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
You cannot sign a valid exit for a validator until it has an index assigned (meaning its in the activation queue at least). You cannot broadcast a valid exit until the validator has been active for at least 27 hours. |
This PR solves 2 issues: 1. Upon signing exits for all validators, Charon does not check if all validators are active. We are changing that to sign only exits for validators that are either queued for activation or active. 2. Upon broadcasting exits for all validators, Charon does not check if all validators are active. We are changing that to broadcast only exits for validators that are active. category: bug ticket: none



This PR solves 2 issues:
category: bug
ticket: none