-
-
Notifications
You must be signed in to change notification settings - Fork 50
Implement Cross-Platform PDF Generation without MS Word dependency #2111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
a212186
c66a05c
89a2cbc
6b66963
9381744
e892cab
0ce5109
c61bb55
c7e8cca
c9f9970
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,10 +12,10 @@ | |
| # - https://pkgs.org/ - resource for finding needed packages | ||
| # - Ex: hexpm/elixir:1.14.2-erlang-25.1.1-debian-bullseye-20220801-slim | ||
| # | ||
| FROM --platform=linux/amd64 hexpm/elixir:1.19-erlang-28.3-debian-bullseye-20251208@sha256:9d1e59c326674de89a2eac9cd7f118ae2917e1c6cde02e8fa4cd785198ca9be0 as builder | ||
| FROM hexpm/elixir:1.19-erlang-28.3-debian-bullseye-20251208@sha256:9d1e59c326674de89a2eac9cd7f118ae2917e1c6cde02e8fa4cd785198ca9be0 AS builder | ||
| # install build dependencies | ||
| RUN apt-get update -y && apt-get install -y build-essential git nodejs npm \ | ||
| && apt-get clean && rm -f /var/lib/apt/lists/*_* | ||
| RUN apt-get update -y && (apt-get install -y build-essential git nodejs npm || (sleep 10 && apt-get update -y && apt-get install -y build-essential git nodejs npm)) \ | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why installing these packages?
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. as this is work on the converter it’s better not to do fixes on copi. If you believe this could be an improvement open an issue and explain why you believe we should do these changes.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. opened a separate issue proposing this as an improvement, with an explanation of why it could be useful. |
||
| && apt-get clean && rm -rf /var/lib/apt/lists/* | ||
|
|
||
| # prepare build dir | ||
| WORKDIR /app | ||
|
|
@@ -58,10 +58,10 @@ RUN mix release | |
|
|
||
| # start a new build stage so that the final image will only contain | ||
| # the compiled release and other runtime necessities | ||
| FROM --platform=linux/amd64 hexpm/elixir:1.19-erlang-28.3-debian-bullseye-20251208@sha256:9d1e59c326674de89a2eac9cd7f118ae2917e1c6cde02e8fa4cd785198ca9be0 | ||
| FROM hexpm/elixir:1.19-erlang-28.3-debian-bullseye-20251208@sha256:9d1e59c326674de89a2eac9cd7f118ae2917e1c6cde02e8fa4cd785198ca9be0 | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix in separate issue.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can be done together with the retry mechanism, but not here. |
||
|
|
||
| RUN apt-get update -y && apt-get install -y libstdc++6 openssl libncurses5 locales \ | ||
| && apt-get clean && rm -f /var/lib/apt/lists/*_* | ||
| RUN apt-get update -y && (apt-get install -y libstdc++6 openssl libncurses5 locales || (sleep 10 && apt-get update -y && apt-get install -y libstdc++6 openssl libncurses5 locales)) \ | ||
| && apt-get clean && rm -rf /var/lib/apt/lists/* | ||
|
|
||
| # Set the locale | ||
| RUN sed -i '/en_US.UTF-8/s/^# //g' /etc/locale.gen && locale-gen | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -56,6 +56,7 @@ Additionally, Adam Shostack maintains a list of tabletop security games and rela | |
|
|
||
| Cornucopia is developed, maintained, updated and promoted by a worldwide team of volunteers. The contributors to date have been: | ||
|
|
||
| - Abhijit | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you can also add your full name. Your choice. |
||
| - Artim Banyte | ||
| - Simon Bennetts | ||
| - Thomas Berson | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe revert this?