Allow package tests to fail gracefully when internet resources are unavailable#107
Merged
stevenpawley merged 3 commits intomainfrom Jul 6, 2025
Merged
Allow package tests to fail gracefully when internet resources are unavailable#107stevenpawley merged 3 commits intomainfrom
stevenpawley merged 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the CRAN policy, "Packages which use Internet resources should fail gracefully with an informative message if the resource is not available or has changed (and not give a check warning nor error)."
This PR updates the
download_nc_basicfunction to provide an informative error message when the GRASS example database cannot be downloaded, but without failing. The test suite has also been updated by addingskip_if(is.null(testdata), "GRASS GIS example dataset is not available")to all tests. Almost all tests are dependent on the availability of the example dataset (except where GRASS is initiated from an externalspatRasterobject). Tests that are dependent on internet resources will be skipped if the example database is not available.