KEH 1761 - Checking Statistics page accuracy #184
Conversation
…ng what is in our TAT and TR onto Statistics page
There was a problem hiding this comment.
I think there may have been a bit of feature creep/misunderstanding here. I understand these are improvements but the ticket was just for checking the data was accurate, but actually, there was a confusion when creating the ticket.
Projects != repositories. On the radar page, a technology can have multiple projects beneath it, then multiple repositories within said project. The mention of Scala listing 4 repositories, but showing only 1 project is correct.
The Statistics page pulls in data from GitHub. The projects mentioned on the Radar page are pulled from the Tech Audit Tool.
I think a separate ticket is to be made if we wanted to implement these features. I do like the tracked projects feature, however I do wonder whether it is necessary and may cause overlap between Statistics page and projects page.
Also why was the toggle button for Tech Radar Only removed?
All the code looks well written though so good job! Tagging @nimshi89 as he created the ticket and @mwirikia for second review :)
| disabled={isLoading} | ||
| aria-label="Select a date range" | ||
| > | ||
| ß |
| Tracked projects are recorded on Tech Audit Tool and shown on | ||
| Tech Radar. |
There was a problem hiding this comment.
Tracked projects are recorded on the Tech Audit Tool and shown on the Tech Radar - better english I think
| Tracked projects are recorded on Tech Audit Tool and shown on | ||
| Tech Radar. |
| .sort-options { | ||
| display: grid; | ||
| grid-template-columns: repeat(auto-fill, minmax(200px, 1fr)); | ||
| grid-template-columns: repeat(auto-fill, minmax(250px, 1fr)); |
There was a problem hiding this comment.
out of interest, why'd you adjust?
| } | ||
|
|
||
| .helpful-hint-text { | ||
| color: gray; |
There was a problem hiding this comment.
use a variable instead like hsl(var(--card-foreground))
| {formatNumberWithCommas(stats.repo_count)} | ||
| </strong>{' '} | ||
| repos | ||
| Total Repositories |
There was a problem hiding this comment.
I've skewed the stats for this but in terms of the text if avg size and avg usage is lowercase, then the total repositories and total projects should lowercase too. I would keep it as just repositories and projects instead of including total. I am open to discussion though.
Yeah after reviewing the ticket again, you are correct, it definitely is confusing. Although the I have confirmed the accuracy of the data. I'll propose a new ticket to @mwirikia about these changes, where if agreed, we can either stick with the tracked projects or come up with another idea. I believe without that then a user may get confused as to why there are differences in the data between the Statistics page and the Tech Radar page. I removed the 'Tech Radar Only' button as I thought with this implementation of "Tracked Projects" it served no purposed but on looking over main branch, my implementation seems to have broken it. I think I'll withdraw this pull request until a decision is made. |
What type of PR is this? (check all applicable)
What
Describe what you have changed and why.
Ticket mentions error. There does not seem to be an error but to clear confusion I have added a new statistic for each language called "Tracked Projects", which refers to the projects included in the Tech Audit Tool and shown on the Tech Radar.
Also removed the "Tech Radar Only" button as this is now added to stats
Testing
Have any new tests been added as part of this issue? If not, try to explain why test coverage is not needed here.
Please write a brief description of why test coverage is not necessary here.
Documentation
Has any new documentation been written as part of this issue? We should try to keep documentation up to date
as new code is added, rather than leaving it for the future.
Please write a brief description of why documentation is not necessary here.
Removed mention of 'Tech Radar only' button
Related issues
Provide links to any related issues.
KEH-1761
How to review
Describe the steps required to test the changes.
Make dev, check if stats match, :)