-
Notifications
You must be signed in to change notification settings - Fork 1
EQS-509 Get validator_version from CIR #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted tests. Further test refactoring required.
petechd
reviewed
Jan 6, 2026
petechd
reviewed
Jan 6, 2026
petechd
reviewed
Jan 6, 2026
petechd
reviewed
Jan 6, 2026
petechd
reviewed
Jan 6, 2026
eq_cir_proxy_service/services/instrument/retrieve_instrument.py
Outdated
Show resolved
Hide resolved
petechd
reviewed
Jan 6, 2026
petechd
reviewed
Jan 6, 2026
eq_cir_proxy_service/services/instrument/retrieve_instrument_metadata.py
Outdated
Show resolved
Hide resolved
petechd
reviewed
Jan 6, 2026
petechd
reviewed
Jan 6, 2026
petechd
reviewed
Jan 7, 2026
petechd
reviewed
Jan 7, 2026
petechd
reviewed
Jan 7, 2026
VirajP1002
reviewed
Jan 7, 2026
…ub.com/ONSdigital/eq-cir-proxy-service into EQS-509-Get-validator_version-from-CIR
petechd
reviewed
Jan 12, 2026
…ub.com/ONSdigital/eq-cir-proxy-service into EQS-509-Get-validator_version-from-CIR
petechd
previously approved these changes
Jan 29, 2026
VirajP1002
reviewed
Jan 30, 2026
eq_cir_proxy_service/services/instrument/retrieve_instrument_metadata.py
Outdated
Show resolved
Hide resolved
VirajP1002
approved these changes
Jan 30, 2026
petechd
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Code modifies the existing 'instrument' proxy endpoint to retrieve the
validator_versionfrom CIR via the v3/ci_metadata endpointWhat has changed
Where the
instrumentendpoint previously took thevalidator_versionfrom the CIR retrieve_collection_instrument endpoint return, it now makes an additional call to the CIR /v3/ci_metadata endpoint to get the instruments metadata, and then uses the containedvalidator_versionvalue.How to test?
/v2/publish_collection_instrumentendpointNote this can also be run locally with eq-runner-mock-cir once the new endpoint is merged, by skipping step 1
Links
https://github.com/ONSdigital/eq-cir-fastapi
https://officefornationalstatistics.atlassian.net/browse/EQS-509