Expand CSV download to methodology and information pages #471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaciekBaron
changed the title
zerolab
requested changes
Jan 30, 2026
| from cms.core.custom_date_format import ons_date_format | ||
|
|
||
| # Re-exports for backwards compatibility | ||
| from cms.core.utils import create_data_csv_download_response_from_data, sanitize_data_for_csv |
Contributor
There was a problem hiding this comment.
question: is this really needed?
| from wagtail.coreutils import WAGTAIL_APPEND_SLASH | ||
|
|
||
| from cms.core.utils import create_data_csv_download_response_from_data, flatten_table_data | ||
| from cms.datavis.constants import CHART_BLOCK_TYPES, TABLE_BLOCK_TYPES |
Contributor
There was a problem hiding this comment.
I know we have a bit of cross-polination here, but seeing this makes me think we're cramming too much in core.
Could this live in its own app data_downloads or something like that? (naming is hard, especially on a Friday afternoon!)
| ) | ||
|
|
||
| # Block type names for table blocks in SectionContentBlock | ||
| TABLE_BLOCK_TYPES: frozenset[str] = frozenset( |
Contributor
There was a problem hiding this comment.
question: should this leave in core blocks? locality of behaviour and all that (ref: SectionContentBlock)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
This PR addresses tickets CMS-972 and CMS-973, and adds support for downloading CSV files from tables and charts from methodology pages, and tables from information pages.
The change involves moving code into a mixin, which we then apply across page models.
The admin URLs have been updated to a more generic structure.
How to review
Follow-up Actions
N/A