Clippy193

.github/workflows/builds.yml

@@ -35,7 +35,7 @@ env:
   # A recent version of stable Rust that is known to pass build, test and other
   # verification steps in this workflow. This was added because using "stable"
   # could cause some steps to fail.
-  RUST_VERSION_KNOWN: "1.91.0"
+  RUST_VERSION_KNOWN: "1.93.0"
 
 jobs:
 

.github/workflows/rust.yml

@@ -61,7 +61,7 @@ jobs:
                 sudo \
                 which \
                 zlib-devel
-      - run: curl https://sh.rustup.rs -sSf | sh -s -- --default-toolchain 1.91.0 -y
+      - run: curl https://sh.rustup.rs -sSf | sh -s -- --default-toolchain 1.93.0 -y
       - run: echo "$HOME/.cargo/bin" >> $GITHUB_PATH
       - run: cargo install bindgen-cli --version 0.66.0
       - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8

rust/src/pop3/pop3.rs

@@ -541,26 +541,27 @@ impl POP3State {
                             flow,
                             direction::Direction::ToClient as i32,
                         );
-                        if response.status == sawp_pop3::Status::OK && tx.request.is_some() {
-                            let command = tx.request.as_ref().unwrap();
-                            SCLogDebug!("command {:?}", command);
-                            match &command.keyword {
-                                sawp_pop3::Keyword::STLS => {
-                                    unsafe {
-                                        SCAppLayerRequestProtocolTLSUpgrade(flow);
-                                    };
+                        if response.status == sawp_pop3::Status::OK {
+                            if let Some(command) = &tx.request {
+                                SCLogDebug!("command {:?}", command);
+                                match &command.keyword {
+                                    sawp_pop3::Keyword::STLS => {
+                                        unsafe {
+                                            SCAppLayerRequestProtocolTLSUpgrade(flow);
+                                        };
+                                    }
+                                    sawp_pop3::Keyword::RETR => {
+                                        // Don't hold onto the whole email body
+
+                                        // TODO: pass off to mime parser
+                                        response.data.clear();
+                                    }
+                                    sawp_pop3::Keyword::AUTH => {
+                                        SCLogDebug!("OK on AUTH, expect base64 blob");
+                                        auth_ok = true;
+                                    }
+                                    _ => {}
                                 }
-                                sawp_pop3::Keyword::RETR => {
-                                    // Don't hold onto the whole email body
-
-                                    // TODO: pass off to mime parser
-                                    response.data.clear();
-                                }
-                                sawp_pop3::Keyword::AUTH => {
-                                    SCLogDebug!("OK on AUTH, expect base64 blob");
-                                    auth_ok = true;
-                                }
-                                _ => {}
                             }
                         }
                         tx.response = Some(response);

rust/src/smb/smb1.rs

@@ -854,8 +854,7 @@ pub fn smb1_trans_request_record(state: &mut SMBState, r: &SmbRecord)
 
             /* if we have a fid, store it so the response can pick it up */
             let mut pipe_dcerpc = false;
-            if rd.pipe.is_some() {
-                let pipe = rd.pipe.unwrap();
+            if let Some(pipe) = rd.pipe {
                 state.ssn2vec_cache.put(SMBCommonHdr::from1(r, SMBHDR_TYPE_GUID),
                         pipe.fid.to_vec());