detect: investigation on single-pkt flows inspection (5180) - v1 #14677
+19
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In corner case scenarios of the engine seeing a single-packet flow started midstream, it would skip certain inspections for the packet due to TCP connection not being established yet. This led to the possibility of a real packet not being blocked, in iPS, or matched against rules, as the corresponding portion of the stream was only inspected later, as part of the stream/flow-timeout logic. Checking if midstream is enabled allows the engine to inspect that traffic earlier, and block the corresponding packet, if need be. Related to Bug OISF#5180
During initialization, the engine reports how many rules were loaded, as well as which types. Pkt-only or stream-pkt rules would cause a "hole" in such stats, as they're not counted.
jufajardini
force-pushed
the
bug-5180-01-single-pkt/v1
branch
from
bad716a to
59d6c49
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14677 +/- ##
=======================================
Coverage 82.11% 82.12%
=======================================
Files 1011 1011
Lines 262812 262825 +13
=======================================
+ Hits 215812 215839 +27
+ Misses 47000 46986 -14
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Forced-push the clang-format fix. |
Member
|
"In corner case scenarios" - please describe the scenario(s) in which this can happen. |
|
Information: QA ran without warnings. Pipeline = 29251 |
catenacyber
requested changes
Jan 23, 2026
Contributor
catenacyber
left a comment
catenacyber
left a comment
There was a problem hiding this comment.
Typo in commit message iPS
Also needs rebase
Contributor
Author
|
another attempt: #14704 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/5180
Describe changes:
connected, yet (noticed while debugging the behavior noticed in tests: check that drop is applied even if alert is discarded - v2 suricata-verify#2863)Provide values to any of the below to override the defaults.
SV_BRANCH=OISF/suricata-verify#2884