Detect transform decompress 7846 v1 #14671
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 7846
Ticket: 7846
catenacyber
requested review from
jasonish,
jufajardini and
victorjulien
as code owners
| } | ||
| } | ||
| } | ||
| let max_size = if let Some(val) = max_size_parsed { |
Member
There was a problem hiding this comment.
we should probably set a max for the max size here, to avoid bad rules. E.g. 1MiB or 8MiB or something.
Contributor
Author
There was a problem hiding this comment.
ok, will add
Investigating why SV fails on 3 runners only (trying to reproduce locally)
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14671 +/- ##
==========================================
- Coverage 82.11% 82.11% -0.01%
==========================================
Files 1011 1012 +1
Lines 262812 262973 +161
==========================================
+ Hits 215812 215941 +129
- Misses 47000 47032 +32
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Replaced by #14674 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7846
Describe changes:
gunziptransformzlib_deflatetransform (maybe we can find a better name)SV_BRANCH=OISF/suricata-verify#2882