Skip to content

Stack 8001 v9 #14659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
catenacyber wants to merge 5 commits into from
Closed

Stack 8001 v9 #14659

catenacyber wants to merge 5 commits into from

Conversation

@catenacyber
Copy link
Contributor

@catenacyber catenacyber commented Jan 20, 2026

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/8001

Describe changes: improve stack allocations

  • allocate on the heap if it can be large
  • adds safety checks or debug validation

#14633 without dummy commit and with last commit extended to cover all uses of buffer_type_id

Still todo after : handle other cases of git grep '\];' src/*.c | grep -v = | grep -v '[0-9]\];' | grep -v '[A-Z]\];' | grep -v return | grep -v g_alproto_max | grep -v '\[\];' | grep -v sizeof after src/detect-engine.c

@catenacyber
datasets: adds safety check before stack allocation
afcb205 
Even if current caller does not provide too big data.

Ticket: 8001
@catenacyber
detect: allocate sids_array on the heap
6edeb4a 
To be able to load 1M signatures and not have a stack overflow

Ticket: 8001
@catenacyber
detect: add debug validation about nlists
81a8102 
To avoid stack overflow

A single signature should not have more than 65k buffers

Ticket: 8001
@catenacyber
detect: allocate arrays on the heap
923c775 
buffer_type_id is a u32

Ticket: 8001
@catenacyber catenacyber mentioned this pull request Jan 20, 2026
Closed
@catenacyber catenacyber marked this pull request as draft January 20, 2026 20:14
@suricata-qa
Copy link

suricata-qa commented Jan 20, 2026

ERROR:
ERROR: SEGMENTATION FAULT in ASAN_TLPR1_cfg QA test

ERROR: QA failed on ASAN_TLPR1_cfg.

Pipeline = 29200

@catenacyber catenacyber mentioned this pull request Jan 20, 2026
Closed
@catenacyber
Copy link
Contributor Author

catenacyber commented Jan 20, 2026

Next in #14661

@catenacyber catenacyber mentioned this pull request Jan 21, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@victorjulien victorjulien Awaiting requested review from victorjulien victorjulien is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@catenacyber @suricata-qa