-
Notifications
You must be signed in to change notification settings - Fork 104
quic: add test for encryption-handling bypass #2819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
catenacyber
wants to merge
1
commit into
OISF:master
from
catenacyber:quic-encryption-handling-8116-v1
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # Test Description | ||
|
|
||
| Tests that the encrypted part of the quic traffic is bypassed | ||
|
|
||
| ## PCAP | ||
|
|
||
| reused | ||
|
|
||
| ## Related issues | ||
|
|
||
| https://redmine.openinfosecfoundation.org/issues/8116 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| requires: | ||
| min-version: 9 | ||
|
|
||
| pcap: ../quic-v2/input.pcap | ||
|
|
||
| args: | ||
| - --set app-layer.protocols.quic.encryption-handling=bypass | ||
| - --set stream.reassembly.depth=1MB | ||
| - --set stream.bypass=false | ||
|
|
||
| checks: | ||
| - filter: | ||
| count: 1 | ||
| match: | ||
| event_type: stats | ||
| - stats: | ||
| flow_bypassed.local_pkts: 13 | ||
| flow_bypassed.local_bytes: 2634 | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stream settings shouldn't affect udp protocols. Did you need to set them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this was meant to me more explicit that the bypass comes from quic and not from stream depth
Removing it