Skip to content

Decompress end v4 #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
catenacyber wants to merge 5 commits into from
Closed

Decompress end v4 #446

catenacyber wants to merge 5 commits into from

Conversation

@catenacyber
Copy link
Contributor

@catenacyber catenacyber commented Mar 13, 2025

#445 with additional commit

To turn 4c2b36da6de0a59451666b8764e66fc222036a35186461cadb96e15a47c03c2b into 6a17e25cd28428d099bb3249a909946b96023cf1d0ea0eeb5e6caf4483021b25 and get closer to libhtp.rs

@catenacyber
decompressors: do not take data after end
1c07fe4
@catenacyber
response: end decompressors in chunked content
c713356 
When a response ends in the middle of a chunk, signal
it to the decompressors to let them finalize the data
they got so far, as is done with content-length.

Do this for all states of chunked content.
@catenacyber
chunks: abort asap on invalid chunk length
76884b5
@catenacyber
chunks: probe validity if data was not buffered
9cc0acd 
If a chunk length line was split in two packets, we buffered
the end of the first packet/beginning of the line, and checked
its validity.
So, do not check further on second packet.
@catenacyber catenacyber mentioned this pull request Mar 13, 2025
Closed
@catenacyber
Copy link
Contributor Author

catenacyber commented Mar 13, 2025 •
edited
Loading

when libhtp.rs has 3 more files


5bf6fda88e45ed8b1b37e1731c8a33a9160541e9513088f07b8f885031d1f963
dc9daad4a8f638a67bdfa94ce12ca0fc4121f57d265a93a861720b4184facc13
e59696229cc023d0d11cbd4cb3b534c46c312a2c2f05f35baaf05c22675b5bf5

@catenacyber
response: do not error on gap finishing content-length
3acaafc 
Passing a gap to a decompressor closes it, but if we also finish
known content-length, we try to reclose decompressor and fail
@catenacyber catenacyber mentioned this pull request Mar 13, 2025
Closed
@catenacyber
Copy link
Contributor Author

catenacyber commented Mar 13, 2025

Next in #447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@catenacyber